Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MochaJS to latest version #65

Merged
merged 3 commits into from Aug 10, 2018
Merged

Update MochaJS to latest version #65

merged 3 commits into from Aug 10, 2018

Conversation

SimonSimCity
Copy link
Member

@SimonSimCity SimonSimCity commented May 22, 2018

In order to keep up with the latest version of MochaJS (and specially for the issue mochajs/mocha#2095 which often ruined the report of my client-tests) I decided to take a look at how we could integrate its latest version.

As https://github.com/practicalmeteor/meteor-mocha-core seems to be abandoned (open PRs are left without any further notification for a long time), I've created a fork on this user (https://github.com/meteortesting/meteor-mocha-core). I first updated to MochaJS in version 3.5.3 and raised the version number to 1.0.1 - MochaJS 4.x.x doesn't seem to support PhantomJS anymore - at least my tests failed (see: Meteor-Community-Packages/meteor-mocha-core#1).

Since the tests only failed in PhantomJS, and the owner of the project decided to has archive it (ariya/phantomjs#15344), I decided to move on and see how far I can get.

I went straight to version 5.2.0, which is the latest as of the time writing, and committed it as a proposal for a 1.0.2 which works great using puppeteer as browser, which is as easy to add as PhantomJS.

Some ideas (some unresolved) still in my head where I want your opinion on:

@aldeed
Copy link
Contributor

aldeed commented Aug 9, 2018

@SimonSimCity I agree with all of that plan. For versioning the fork of core, Meteor allows you to use an underscore, so a common pattern is <wrapped_package_version>_<additional integer>. i.e. you could publish the one wrapping 5.2.0 as 5.2.0_1 and if you need to republish a change that doesn't change which mocha is wrapped, it would be 5.2.0_2. See the description for version option here: https://docs.meteor.com/api/packagejs.html#PackageNamespace-describe

@SimonSimCity
Copy link
Member Author

@aldeed I've now updated the PR. Could you please merge it or grant me access to do so, and also the permission to update the repository?

@SimonSimCity SimonSimCity merged commit f8c1b5a into Meteor-Community-Packages:master Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants