Skip to content

Commit

Permalink
fix: "ERR_INVALID_THIS" on Node 20 (remix-run#32)
Browse files Browse the repository at this point in the history
* fix: node 20

pnpm/node-fetch#1
Signed-off-by: Logan McAnsh <logan@mcan.sh>

* ci: test against more node versions

Signed-off-by: Logan McAnsh <logan@mcan.sh>

* ci: update action versions

Signed-off-by: Logan McAnsh <logan@mcan.sh>

* chore: remove nested .github dir

Signed-off-by: Logan McAnsh <logan@mcan.sh>

* ci: disable fail fast

Signed-off-by: Logan McAnsh <logan@mcan.sh>

* ci: new server per test

Signed-off-by: Logan McAnsh <logan@mcan.sh>

* test: update family agent option test

Signed-off-by: Logan McAnsh <logan@mcan.sh>

* Create polite-eggs-jam.md

* test: use ipv4

Signed-off-by: Logan McAnsh <logan@mcan.sh>

* test: use family 0

Signed-off-by: Logan McAnsh <logan@mcan.sh>

---------

Signed-off-by: Logan McAnsh <logan@mcan.sh>
  • Loading branch information
mcansh authored and MichaelDeBoey committed Aug 29, 2023
1 parent c770c7f commit 5d9b34c
Show file tree
Hide file tree
Showing 18 changed files with 1,353 additions and 1,459 deletions.
5 changes: 5 additions & 0 deletions .changeset/polite-eggs-jam.md
@@ -0,0 +1,5 @@
---
"@remix-run/web-fetch": patch
---

fixes "ERR_INVALID_THIS" on Node 20
11 changes: 7 additions & 4 deletions .github/workflows/blob.yml
Expand Up @@ -23,10 +23,10 @@ jobs:
project:
- blob
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3

- name: Setup node ${{ matrix.node-version }}
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}

Expand All @@ -42,10 +42,13 @@ jobs:
runs-on: ${{ matrix.os }}

strategy:
fail-fast: false
matrix:
node-version:
- 14
- 16
- 18
- 20
os:
- ubuntu-latest
- windows-latest
Expand All @@ -54,10 +57,10 @@ jobs:
- blob

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3

- name: Setup Node
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}

Expand Down
11 changes: 7 additions & 4 deletions .github/workflows/fetch.yml
Expand Up @@ -24,10 +24,10 @@ jobs:
project:
- fetch
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3

- name: Setup node ${{ matrix.node-version }}
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}

Expand All @@ -44,10 +44,13 @@ jobs:
runs-on: ${{ matrix.os }}

strategy:
fail-fast: false
matrix:
node-version:
- 14
- 16
- 18
- 20
os:
- ubuntu-latest
- windows-latest
Expand All @@ -62,10 +65,10 @@ jobs:
node-version: 14

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3

- name: Setup Node
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}

Expand Down
11 changes: 7 additions & 4 deletions .github/workflows/file.yml
Expand Up @@ -23,10 +23,10 @@ jobs:
project:
- file
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3

- name: Setup node ${{ matrix.node-version }}
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}

Expand All @@ -42,10 +42,13 @@ jobs:
runs-on: ${{ matrix.os }}

strategy:
fail-fast: false
matrix:
node-version:
- 14
- 16
- 18
- 20
os:
- ubuntu-latest
- windows-latest
Expand All @@ -54,10 +57,10 @@ jobs:
- file

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3

- name: Setup Node
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}

Expand Down
11 changes: 7 additions & 4 deletions .github/workflows/form-data.yml
Expand Up @@ -24,10 +24,10 @@ jobs:
project:
- form-data
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3

- name: Setup node ${{ matrix.node-version }}
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}

Expand All @@ -43,10 +43,13 @@ jobs:
runs-on: ${{ matrix.os }}

strategy:
fail-fast: false
matrix:
node-version:
- 14
- 16
- 18
- 20
os:
- ubuntu-latest
- windows-latest
Expand All @@ -55,10 +58,10 @@ jobs:
- form-data

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3

- name: Setup Node
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}

Expand Down
15 changes: 9 additions & 6 deletions .github/workflows/stream.yml
Expand Up @@ -24,10 +24,10 @@ jobs:
- stream
steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v3

- name: Setup node ${{ matrix.node-version }}
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}

Expand All @@ -43,10 +43,13 @@ jobs:
runs-on: ${{ matrix.os }}

strategy:
fail-fast: false
matrix:
node-version:
- 14
- 16
- 18
- 20
os:
- ubuntu-latest
- windows-latest
Expand All @@ -56,10 +59,10 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v3

- name: Setup Node
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}

Expand All @@ -84,10 +87,10 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v3

- name: Setup Node
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: 16

Expand Down
12 changes: 0 additions & 12 deletions packages/fetch/.github/FUNDING.yml

This file was deleted.

40 changes: 0 additions & 40 deletions packages/fetch/.github/ISSUE_TEMPLATE/bug_report.md

This file was deleted.

5 changes: 0 additions & 5 deletions packages/fetch/.github/ISSUE_TEMPLATE/config.yml

This file was deleted.

21 changes: 0 additions & 21 deletions packages/fetch/.github/ISSUE_TEMPLATE/feature-request.md

This file was deleted.

40 changes: 0 additions & 40 deletions packages/fetch/.github/ISSUE_TEMPLATE/support-or-usage.md

This file was deleted.

20 changes: 0 additions & 20 deletions packages/fetch/.github/PULL_REQUEST_TEMPLATE.md

This file was deleted.

0 comments on commit 5d9b34c

Please sign in to comment.