Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: try to make token generation more robust against bad connection #1045

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MichaelMure
Copy link
Owner

No description provided.

@akhavr
Copy link

akhavr commented Mar 10, 2023

Sometimes it fails even earlier:

Select option: 1
Github login: akhavr
Error: Get "https://api.github.com/users/akhavr": read tcp 192.168.1.193:52634->140.82.121.6:443: read: connection reset by peer

Will play more with the bridge creation trying to catch most failure modes.

Copy link
Collaborator

@smoyer64 smoyer64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we adopt something like backoff? (https://pkg.go.dev/github.com/cenkalti/backoff/v4). This is probably not the only place that would benefit from retries. We should also output a warning if the users GITHUB_TOKEN isn't valid (has expired, etc) since you technically have a token but you're still rate-limited like an unauthorized user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants