WIP: Gitea/Forgejo bridge #1077
Conversation
This a just a preview. Not all features are expected to work.
The features aren't yet filled out, and are represented ❓, but are at least present and aligned for readability.
There was a problem hiding this comment.
Well, as a maintainer, I see the value of having such a bridge, but it's also a bit scary to merge (and have to maintain) a bridge with zero tests, and incomplete like this.
There is a few tiny fixes to do, but the biggest issue is not having the capability to import comments. It seems like it greatly reduce the usefulness of such importer.
Do you think you could implement that part? It seems like there is already the corresponding iterator, it should be "just" a matter of replicating that data into git-bug.
| return | ||
| } | ||
|
|
||
| // Loop over all comments |
There was a problem hiding this comment.
looks like this is a quite important missing feature, no?
| // TODO: validate username | ||
| login, err = input.Prompt("Gitea login", "login", input.Required) | ||
| } else { | ||
| // TODO: validate username |
There was a problem hiding this comment.
todo: at least make sure it's not empty, return an error if so
| ) | ||
|
|
||
| // giteaExporter implement the Exporter interface | ||
| type giteaExporter struct { |
There was a problem hiding this comment.
this whole exporter could be removed (as it's not used), instead of returning those weird errors
| ) | ||
|
|
||
| const ( | ||
| target = "gitea-preview" |
There was a problem hiding this comment.
| target = "gitea-preview" | |
| target = "gitea" |
|
Oh for sure; there's significant work to be done before it's remotely merge-able, hence the "WIP" and "Draft" status. I'm not sure when I'll be in a position to do more than I have already, but wanted to at least share the progress of bringing the previous PRs up to a state where they at least compile and run on the current code-base. Thanks for the direction in your comments, though; that will certainly make it easier to make a start on this. :) |
|
Any thoughts on Forgejo vs Gitea? Looks like they should be basically compatible, and have a good amount of momentum behind them. |
|
Software-wise they're currently identical since Forgejo is a soft fork. |
|
They're very much compatible at the moment; Gitea clients will work perfectly with Forgejo servers. I do know some of the people behind Forgejo are also some of the people behind ForgeFed and they're putting a lot of effort into implementing it. If I remember correctly, the primary Gitea maintainers were pretty ambivalent to federated forges, so I can definitely see them diverging in that area further down the line. |
This PR deprecates #1017 (and #890 and #645 before it). I've rebased off current
master, updated the feature matrix to the best of my ability, and built the code to confirm I can pull bugs from a Gitea repo.I've not done anything else so far. I'm very new to Go, so am starting small, but wanted to at least give this a shot because having a Gitea bridge would be valuable to me.