Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade go-git to v5.5.1 #963

Merged
merged 2 commits into from Jan 2, 2023
Merged

Conversation

smoyer64
Copy link
Collaborator

Related to #934

@MichaelMure
Copy link
Owner

There is also #947, but it looks like some things are breaking in git-bug.

@smoyer64
Copy link
Collaborator Author

Yeah ... I didn't notice the one started by dependabot. I'm tracking down the Go panic (it's the crypto checking the signing).

@smoyer64 smoyer64 changed the title feat: upgrade go-git to v5.1.1 feat: upgrade go-git to v5.5.1 Dec 31, 2022
@smoyer64
Copy link
Collaborator Author

We should talk about what our goals are for commit signing and use cases for those who already have keys. This will obviously also impact how the bridges work since ideally we'd be able to verify signed commits from the "forges".

@MichaelMure
Copy link
Owner

We should talk about what our goals are for commit signing and use cases for those who already have keys. This will obviously also impact how the bridges work since ideally we'd be able to verify signed commits from the "forges".

Does that answer your question? #130

As for the bridges, I'd think the only interaction with keys would be to import the public keys when creating or updating the identities. That way, anyone having the matching private key would be able to adopt the identity without losing the history.

@smoyer64 smoyer64 merged commit a4cee75 into master Jan 2, 2023
@smoyer64 smoyer64 deleted the feat/upgrade-go-git-v5.1.1 branch January 2, 2023 13:08
@smoyer64
Copy link
Collaborator Author

smoyer64 commented Jan 2, 2023

I'll add a few comments to #130 instead of them languishing here on a closed PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants