New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial working site implementation. #60
Conversation
Co-authored-by: Emmanuel ifeanyichukwu <amahe8664@gmail.com>
…al score: player-score
Co-authored-by: Cornelius Owusu-Ansah <thecornisians@gmail.com>
… to process api parameters).
As of now this is all the work i have done. The last item still needs to be done for which i will try to get to today. EDIT: In the future i might change a portion of the api to use a POST request (for example checking if the user should get a point) EDIT 2: I will probably limit the pr to this and create the another that handles the winning condition in another. This already has a ton of changes that will make it difficult to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one thing, however, from what I recall the API returns an ID for each pokemon card. in the form of an array of objects, each object containing data on the card, and one of those properties being an ID.
The only problem is the client does not retain that info. I could have made that change (keeping the id) either keeping in JavaScript or putting it as a element attribute, but as you can imagine it would have created more changes (and more code commits). Id be more than happy to create another issue (or have anyone else create an issue tracking this) but i would want to keep that seperate to this PR. |
This PR will merge into the master branch a working implementation of the site.
This is still a WIP as i have not committed the whole site and(The code has been committed already)There is still the question of what to do when the user gets a full score.(will be implemented in another PR). For the moment the following things are functional: