Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(inheritance): allow for returning plain objects #279

Merged
merged 1 commit into from
Mar 16, 2019
Merged

fix(inheritance): allow for returning plain objects #279

merged 1 commit into from
Mar 16, 2019

Conversation

MichalLytek
Copy link
Owner

@MichalLytek MichalLytek commented Mar 13, 2019 •
edited

Pretty dirty solution but should be enough as a temporary fix until #183 will be achieved 馃挭

Closes #160 馃敀

@MichalLytek MichalLytek added the Bug 馃悰 Something isn't working label Mar 13, 2019
@MichalLytek MichalLytek added this to the 1.0.0 release milestone Mar 13, 2019
@MichalLytek MichalLytek self-assigned this Mar 13, 2019
@MichalLytek MichalLytek added this to In review in Board via automation Mar 13, 2019
@MichalLytek MichalLytek mentioned this pull request Mar 13, 2019
Closed
@codecov
Copy link

codecov bot commented Mar 13, 2019 •
edited

Codecov Report

Merging #279 into master will decrease coverage by 0.37%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #279      +/-   ##
==========================================
- Coverage   95.67%   95.29%   -0.38%     
==========================================
  Files          67       68       +1     
  Lines         947      956       +9     
  Branches       72       72              
==========================================
+ Hits          906      911       +5     
- Misses         38       42       +4     
  Partials        3        3
Impacted Files Coverage 螖
src/errors/index.ts 100% <100%> (酶) 猬嗭笍
src/errors/InterfaceResolveTypeError.ts 100% <100%> (酶)
src/schema/schema-generator.ts 96.23% <100%> (+0.1%) 猬嗭笍
src/utils/createResolversMap.ts 79.31% <0%> (-13.8%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 572eddd...c22c135. Read the comment docs.

@MichalLytek MichalLytek force-pushed the fix/inheritance-returns-plain-objects branch from 789bceb to 2ef4f5e Compare March 13, 2019 21:52
@MichalLytek MichalLytek force-pushed the fix/inheritance-returns-plain-objects branch from 2ef4f5e to c22c135 Compare March 16, 2019 17:00
@MichalLytek MichalLytek merged commit 867f0f8 into master Mar 16, 2019
Board automation moved this from In review to Done Mar 16, 2019
@MichalLytek MichalLytek deleted the fix/inheritance-returns-plain-objects branch March 16, 2019 17:04
@MichalLytek MichalLytek mentioned this pull request Mar 23, 2019
Closed
@MichalLytek MichalLytek mentioned this pull request Jul 8, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hcharley hcharley hcharley left review comments

Assignees

@MichalLytek MichalLytek

Labels
Bug 馃悰 Something isn't working
Projects
Board
  
Done
Milestone
1.0.0 release
Development

Successfully merging this pull request may close these issues.

Cannot return plain objects when using inherited ObjectTypes
2 participants
@MichalLytek @hcharley