Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update graphql-query-complexity to ^0.6.0 #639

Conversation

robhogan
Copy link

@robhogan robhogan commented May 28, 2020

Currently there's a warning on installation alongside graphql@15:

type-graphql > graphql-query-complexity@0.5.0" has incorrect peer dependency "graphql@^0.13.0 || ^14.0.0"

graphql-query-complexity@0.6.0 recently widened its peer dependencies to include graphql@^15.0.0.

It dropped legacyEstimator and fieldConfigEstimator in the process, but it looks like this library doesn't use the former and has just moved away from the latter (both were already deprecated in 0.5.0).

This PR updates the dependency to ^0.6.0.

@codecov
Copy link

codecov bot commented May 28, 2020

Codecov Report

Merging #639 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #639   +/-   ##
=======================================
  Coverage   95.21%   95.21%           
=======================================
  Files          78       78           
  Lines        1442     1442           
  Branches      286      286           
=======================================
  Hits         1373     1373           
  Misses         66       66           
  Partials        3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31f828e...e143130. Read the comment docs.

@robhogan robhogan mentioned this pull request May 28, 2020
@MichalLytek
Copy link
Owner

@rh389 Thanks for the PR!

However, I've just updated all the deps, which superseeds your PR 🤐
Closing via 38334d0 🔒

@MichalLytek MichalLytek added Chore 🔨 Work not related with main project goal Community 👨‍👧 Something initiated by a community Duplicate 🔑 This issue or pull request already exists labels May 28, 2020
@robhogan
Copy link
Author

“Duplicate” is a little harsh, but otherwise no problem! 😉

Cheers for the library 👍

@robhogan robhogan deleted the feature/update-graphql-query-complexity branch May 28, 2020 19:19
@MichalLytek
Copy link
Owner

Sorry, I don't have the "outdated" label and I found that less offensive than "invalid" 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chore 🔨 Work not related with main project goal Community 👨‍👧 Something initiated by a community Duplicate 🔑 This issue or pull request already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants