Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database: Implement connection pooling and context cacellation #18

Merged
merged 5 commits into from Jan 16, 2024

Conversation

robertoesteves13
Copy link
Contributor

It includes some improvements in how a guild is initialized in database, but it requires rawdogging some SQL until this issue gets fixed.. I also changed to get the API key using the Authorization header because the database was trying to use it to query the table, resulting in an error.

Closes #15

database/guilds.go Outdated Show resolved Hide resolved
Copy link
Owner

@Miconen Miconen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good except inserting a user which fails due to line 80

Copy link
Owner

@Miconen Miconen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, ty

@Miconen Miconen merged commit b194872 into Miconen:main Jan 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transfer db connectivity to use pooling
2 participants