chore: miscellaneous typos #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package-lock.json should match the package.json version
|
|
asos-craigmorten
changed the title
markwolff
approved these changes
Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
No Issue.
Details
I have been reading the source code, as prompted by a few places in the README to get a better understanding of AI and it's API / functionality.
While doing so I've noticed a few typos so thought I might as well put in a PR to fix up documentation!
Most changes are to comments with the following exceptions:
existance->existencein Library/NodeClient.ts for theLogging.info(Sender.TAG, ...)messages. I am not aware how this is relied upon so can happily revert if this is considered a breaking change.*.bondfiles.npm install.The Contributing don't offer much in way of branching strategy etc. guidance, so please let me know if need anything more / different from this PR! 馃槃
Tests
Following tests pass locally:
npm run testnpm run backcompattestnpm run functionaltestBuild
Following build steps complete without exception locally:
npm run build