Skip to content

Commit

Permalink
chore: miscellaneous typos (#622)
Browse files Browse the repository at this point in the history
* fix: following contributing guidelines resulted in updated package-lock

package-lock.json should match the package.json version

* fix: all typos found
  • Loading branch information
asos-craigmorten committed Apr 30, 2020
1 parent 162ace2 commit 44a0e7f
Show file tree
Hide file tree
Showing 16 changed files with 21 additions and 21 deletions.
4 changes: 2 additions & 2 deletions AutoCollection/HttpDependencyParser.ts
Expand Up @@ -11,7 +11,7 @@ import RequestParser = require("./RequestParser");
import CorrelationIdManager = require("../Library/CorrelationIdManager");

/**
* Helper class to read data from the requst/response objects and convert them into the telemetry contract
* Helper class to read data from the request/response objects and convert them into the telemetry contract
*/
class HttpDependencyParser extends RequestParser {
private correlationId: string;
Expand Down Expand Up @@ -127,7 +127,7 @@ class HttpDependencyParser extends RequestParser {
options.search = parsedQuery.search;
}

// Simiarly, url.format ignores hostname and port if host is specified,
// Similarly, url.format ignores hostname and port if host is specified,
// even if host doesn't have the port, but http.request does not work
// this way. It will use the port if one is not specified in host,
// effectively treating host as hostname, but will use the port specified
Expand Down
2 changes: 1 addition & 1 deletion AutoCollection/HttpRequestParser.ts
Expand Up @@ -13,7 +13,7 @@ import Tracestate = require("../Library/Tracestate");
import Traceparent = require("../Library/Traceparent");

/**
* Helper class to read data from the requst/response objects and convert them into the telemetry contract
* Helper class to read data from the request/response objects and convert them into the telemetry contract
*/
class HttpRequestParser extends RequestParser {
private static keys = new Contracts.ContextTagKeys();
Expand Down
2 changes: 1 addition & 1 deletion AutoCollection/RequestParser.ts
@@ -1,5 +1,5 @@
/**
* Base class for helpers that read data from HTTP requst/response objects and convert them
* Base class for helpers that read data from HTTP request/response objects and convert them
* into the telemetry contract objects.
*/
abstract class RequestParser {
Expand Down
2 changes: 1 addition & 1 deletion Bootstrap/DataModel.ts
Expand Up @@ -36,7 +36,7 @@ export interface DiagnosticLog {
exception?: string

/**
* Any custom data related to the error/application/operation. Each field should havea string value
* Any custom data related to the error/application/operation. Each field should have a string value
* Examples: operation, siteName, ikey, extensionVersion, sdkVersion, subscriptionId
*/
properties: { [key: string]: string };
Expand Down
2 changes: 1 addition & 1 deletion Bootstrap/Default.ts
Expand Up @@ -31,7 +31,7 @@ export function setLogger(logger: DiagnosticLogger) {
}

/**
* Sets the string which is prefixed to the exsting sdkVersion, e.g. `ad_`, `alr_`
* Sets the string which is prefixed to the existing sdkVersion, e.g. `ad_`, `alr_`
* @param prefix string prefix, including underscore. Defaults to `ad_`
*/
export function setUsagePrefix(prefix: string) {
Expand Down
2 changes: 1 addition & 1 deletion Declarations/Contracts/TelemetryTypes/RequestTelemetry.ts
@@ -1,7 +1,7 @@
import { Telemetry } from "./Telemetry";

/**
* Telemetry about the incoming request processsed by the application
* Telemetry about the incoming request processed by the application
*/
export interface RequestTelemetry extends Telemetry
{
Expand Down
4 changes: 2 additions & 2 deletions Declarations/Contracts/TelemetryTypes/Telemetry.ts
@@ -1,9 +1,9 @@
/**
* Base telemetry interface encapsulating comming properties
* Base telemetry interface encapsulating coming properties
*/
export interface Telemetry {
/**
* Telemetry time stamp. When it is not specified, current tiestamp will be used.
* Telemetry time stamp. When it is not specified, current timestamp will be used.
*/
time?: Date;
/**
Expand Down
2 changes: 1 addition & 1 deletion Library/Channel.ts
Expand Up @@ -26,7 +26,7 @@ class Channel {
/**
* Enable or disable disk-backed retry caching to cache events when client is offline (enabled by default)
* These cached events are stored in your system or user's temporary directory and access restricted to your user when possible.
* @param value if true events that occured while client is offline will be cached on disk
* @param value if true events that occurred while client is offline will be cached on disk
* @param resendInterval The wait interval for resending cached events.
* @param maxBytesOnDisk The maximum size (in bytes) that the created temporary directory for cache events can grow to, before caching is disabled.
* @returns {Configuration} this class
Expand Down
2 changes: 1 addition & 1 deletion Library/Config.ts
Expand Up @@ -92,7 +92,7 @@ class Config {
this.httpsAgent = undefined;
this.profileQueryEndpoint = csCode.ingestionendpoint || csEnv.ingestionendpoint || process.env[Config.ENV_profileQueryEndpoint] || this.endpointBase;
this._quickPulseHost = csCode.liveendpoint || csEnv.liveendpoint || process.env[Config.ENV_quickPulseHost] || Constants.DEFAULT_LIVEMETRICS_HOST;
// Parse quickPulseHost if it startswith http(s)://
// Parse quickPulseHost if it starts with http(s)://
if (this._quickPulseHost.match(/^https?:\/\//)) {
this._quickPulseHost = url.parse(this._quickPulseHost).host;
}
Expand Down
2 changes: 1 addition & 1 deletion Library/NodeClient.ts
Expand Up @@ -15,7 +15,7 @@ import Contracts = require("../Declarations/Contracts");
class NodeClient extends TelemetryClient {

/**
* Log RequestTelemetry from HTTP request and response. This method will log immediately without waitng for request completion
* Log RequestTelemetry from HTTP request and response. This method will log immediately without waiting for request completion
* and it requires duration parameter to be specified on NodeHttpRequestTelemetry object.
* Use trackNodeHttpRequest function to log the telemetry after request completion
* @param telemetry Object encapsulating incoming request, response and duration information
Expand Down
4 changes: 2 additions & 2 deletions Library/RequestResponseHeaders.ts
Expand Up @@ -23,13 +23,13 @@ export = {
requestIdHeader: "request-id",

/**
* Legacy Header containing the id of the immidiate caller
* Legacy Header containing the id of the immediate caller
*/
parentIdHeader: "x-ms-request-id",

/**
* Legacy Header containing the correlation id that kept the same for every telemetry item
* accross transactions
* across transactions
*/
rootIdHeader: "x-ms-request-root-id",

Expand Down
6 changes: 3 additions & 3 deletions Library/Sender.ts
Expand Up @@ -19,7 +19,7 @@ class Sender {
private static ACLED_DIRECTORIES: {[id: string]: boolean} = {};
private static ACL_IDENTITY: string = null;

// the amount of time the SDK will wait between resending cached data, this buffer is to avoid any throtelling from the service side
// the amount of time the SDK will wait between resending cached data, this buffer is to avoid any throttling from the service side
public static WAIT_BETWEEN_RESEND = 60 * 1000;
public static MAX_BYTES_ON_DISK = 50 * 1000 * 1000;
public static MAX_CONNECTION_FAILURES_BEFORE_WARN = 5;
Expand Down Expand Up @@ -396,7 +396,7 @@ class Sender {

// This will create the dir if it does not exist
// Default permissions on *nix are directory listing from other users but no file creations
Logging.info(Sender.TAG, "Checking existance of data storage directory: " + directory);
Logging.info(Sender.TAG, "Checking existence of data storage directory: " + directory);
this._confirmDirExists(directory, (error) => {
if (error) {
Logging.warn(Sender.TAG, "Error while checking/creating directory: " + (error && error.message));
Expand Down Expand Up @@ -436,7 +436,7 @@ class Sender {
var directory = path.join(os.tmpdir(), Sender.TEMPDIR_PREFIX + this._config.instrumentationKey);

try {
Logging.info(Sender.TAG, "Checking existance of data storage directory: " + directory);
Logging.info(Sender.TAG, "Checking existence of data storage directory: " + directory);
if (!fs.existsSync(directory)) {
fs.mkdirSync(directory);
}
Expand Down
2 changes: 1 addition & 1 deletion Schema/PublicSchema/ContextTagKeys.bond
Expand Up @@ -82,7 +82,7 @@ struct ContextTagKeys
[MaxStringLength("256")]
705: string CloudRole = "ai.cloud.role";

[Description("Name of the instance where the application is running. Computer name for on-premisis, instance name for Azure.")]
[Description("Name of the instance where the application is running. Computer name for on-premises, instance name for Azure.")]
[MaxStringLength("256")]
715: string CloudRoleInstance = "ai.cloud.roleInstance";

Expand Down
2 changes: 1 addition & 1 deletion Schema/PublicSchema/RemoteDependencyData.bond
Expand Up @@ -26,7 +26,7 @@ struct RemoteDependencyData
[ActAsRequired("Renaming value to duration.")]
61: required string duration;

[Description("Indication of successfull or unsuccessfull call.")]
[Description("Indication of successful or unsuccessful call.")]
120: nullable<bool> success = true;

[MaxStringLength("8192")]
Expand Down
2 changes: 1 addition & 1 deletion Schema/PublicSchema/RequestData.bond
Expand Up @@ -21,7 +21,7 @@ struct RequestData
[Description("Result of a request execution. HTTP status code for HTTP requests.")]
60: required string responseCode;

[Description("Indication of successfull or unsuccessfull call.")]
[Description("Indication of successful or unsuccessful call.")]
70: required bool success;

[MaxStringLength("1024")]
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 44a0e7f

Please sign in to comment.