Handle when change in type of dts may result in only dts emit but not js emit #30971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ending affected files
…ypes indirectly mean d.ts change too (not just semantic diagnostics)
…fects dts but not js file
sheetalkamat
requested review from
rbuckton,
andrewbranch,
RyanCavanaugh,
sandersn and
weswigham
…dules and their dts emit
sandersn
requested changes
Apr 17, 2019
sandersn
approved these changes
Apr 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already handled semantic diagnostics for such files but we need to also do emit for these files if dts emit is enabled
Fixes #30780