Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle when change in type of dts may result in only dts emit but not js emit #30971

Merged
merged 8 commits into from Apr 24, 2019
Merged

Handle when change in type of dts may result in only dts emit but not js emit #30971

merged 8 commits into from Apr 24, 2019

Commits on Apr 16, 2019

  1. Write test case that baselines the incremental build result 

    Testcase for #30780
    @sheetalkamat
    sheetalkamat committed Apr 16, 2019
    Copy the full SHA
    707cb93 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary check since seenEmittedFiles is set when getting p… 

    …ending affected files
    @sheetalkamat
    sheetalkamat committed Apr 16, 2019
    Copy the full SHA
    0be9a22 View commit details
    Browse the repository at this point in the history

  3. When exported types from module change, the modules exporting these t… 

    …ypes indirectly mean d.ts change too (not just semantic diagnostics)
    @sheetalkamat
    sheetalkamat committed Apr 16, 2019
    Copy the full SHA
    db8c6ee View commit details
    Browse the repository at this point in the history

  4. Handle dts change as well as signature update when exported module af… 

    …fects dts but not js file
    @sheetalkamat
    sheetalkamat committed Apr 16, 2019
    Copy the full SHA
    17d2c8b View commit details
    Browse the repository at this point in the history

  5. Combine semantic diagnostics of files using exported entities from mo… 

    …dules and their dts emit
    @sheetalkamat
    sheetalkamat committed Apr 16, 2019
    Copy the full SHA
    ae7e00e View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2019

  1. Code review feedback

    @sheetalkamat
    sheetalkamat committed Apr 17, 2019
    Copy the full SHA
    4a55025 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into dtsSignatureChange

    @sheetalkamat
    sheetalkamat committed Apr 17, 2019
    Copy the full SHA
    d5100bb View commit details
    Browse the repository at this point in the history

  3. Handle simple lib file in the test case

    @sheetalkamat
    sheetalkamat committed Apr 17, 2019
    Copy the full SHA
    2a29880 View commit details
    Browse the repository at this point in the history