Fix failing 3.11 Windows tests due to temporary files #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I couldn't replicate this locally at all (something specific to the runner?). I eventually found this [pytest issue](pytest-dev/pytest#7491) that discusses similar(ish) behaviors. This lead me to attempt to catch the PermissionError exception and essentially ignore it. I'm not sure if this is a good approach, but it appears to resolve the issue.
|
First of all, that was some great detective work. Nice job digging into this. I think the solution is great. If I was really wanting to dig deep, I'd say we should bury the exception handling a little lower in the |
Mikuana
approved these changes
May 11, 2024
Mikuana
added a commit
that referenced
this pull request
May 11, 2024
* Working on rules for sn identification * Refine regex Adding tests * Build update Adding latest pythons and removing mac-os because it's complaining. `Version 3.7 with arch x64 not found` * Make '3.10' explicit Build treated this as 3.1 * Add Number to ALL import So this field gets brought in with others on a * import. * Add readthedocs config Required to build. * Remove comments * Add sphinx requirements * Ignore cleanup errors for temp directories We don't really care about the details of why this isn't working I don't think. Our runner is ephemeral so who cares if something goes weird with the test cleanup? * Revert "Ignore cleanup errors for temp directories" This reverts commit d749102. * Conditionally ignore cleanup errors in newer versions of python tests * Mark extra function as a fixture.... * Revert "Mark extra function as a fixture...." This reverts commit 29361b4. * Revert "Conditionally ignore cleanup errors in newer versions of python tests" This reverts commit 2a9d47a. * Revert "Revert "Ignore cleanup errors for temp directories"" This reverts commit 134997d. * Revert "Ignore cleanup errors for temp directories" This reverts commit d749102. * Add exception handling to usage of tempfile.TemporaryDirectory() (#111) I couldn't replicate this locally at all (something specific to the runner?). I eventually found this [pytest issue](pytest-dev/pytest#7491) that discusses similar(ish) behaviors. This lead me to attempt to catch the PermissionError exception and essentially ignore it. I'm not sure if this is a good approach, but it appears to resolve the issue. Co-authored-by: Jacob Campbell <jacob.campbell@hca.wa.gov> * whitespace * bump --------- Co-authored-by: Jacob Campbell <jacob.campbell@hca.wa.gov> Co-authored-by: Snotpus <jacobl.campbell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't replicate these tests failing locally at all (something specific to the runner?).
I eventually found this pytest issue that discusses
similar(ish) behaviors. This lead me to attempt to catch the PermissionError exceptions and essentially ignore them.
I'm not sure if this is a good approach, but it appears to resolve the issue.