fix: 🐛 input chip disappeared in bind mode

✅ Closes: #513
Milkdown · May 17, 2022 · 53d4cfc · 53d4cfc · vercel · May 17, 2022
1 parent 84aa915
commit 53d4cfc
Show file tree

Hide file tree

Showing 6 changed files with 62 additions and 144 deletions.
diff --git a/examples/collaboration/main.ts b/examples/collaboration/main.ts
@@ -3,7 +3,7 @@
 import { defaultValueCtx, Editor, rootCtx } from '@milkdown/core';
 import { collaborative, collabServiceCtx } from '@milkdown/plugin-collaborative';
 import { math } from '@milkdown/plugin-math';
-import { commonmark } from '@milkdown/preset-commonmark';
+import { gfm } from '@milkdown/preset-gfm';
 import { nord } from '@milkdown/theme-nord';
 import { WebsocketProvider } from 'y-websocket';
 import { Doc } from 'yjs';
@@ -37,7 +37,7 @@ async function main() {
             ctx.set(defaultValueCtx, markdown);
         })
         .use(nord)
-        .use(commonmark)
+        .use(gfm)
         .use(math)
         .use(collaborative)
         .create();

diff --git a/examples/collaboration/package.json b/examples/collaboration/package.json
@@ -12,6 +12,7 @@
         "@milkdown/core": "workspace:*",
         "@milkdown/prose": "workspace:*",
         "@milkdown/preset-commonmark": "workspace:*",
+        "@milkdown/preset-gfm": "workspace:*",
         "@milkdown/theme-nord": "workspace:*",
         "@milkdown/plugin-math": "workspace:*",
         "@milkdown/plugin-collaborative": "workspace:*",

diff --git a/packages/plugin-math/src/math-inline/index.ts b/packages/plugin-math/src/math-inline/index.ts
@@ -173,9 +173,7 @@ export const mathInline = createNode<string, Options>((utils, options) => {
                         });
                         if (!inputChipRenderer) return {};
                         const shouldDisplay = (view: EditorView) => {
-                            return Boolean(
-                                view.hasFocus() && type && findSelectedNodeOfType(view.state.selection, type),
-                            );
+                            return Boolean(type && findSelectedNodeOfType(view.state.selection, type));
                         };
                         const getCurrentLink = (view: EditorView) => {
                             const result = findSelectedNodeOfType(view.state.selection, type);

diff --git a/packages/preset-gfm/src/footnote/definition.ts b/packages/preset-gfm/src/footnote/definition.ts
@@ -135,11 +135,8 @@ export const footnoteDefinition = createNode((utils) => {
                             isBindMode: true,
                         });
                         if (!inputChipRenderer) return {};
-                        const shouldDisplay = (view: EditorView) => {
-                            return Boolean(
-                                view.hasFocus() && type && findSelectedNodeOfType(view.state.selection, type),
-                            );
-                        };
+                        const shouldDisplay = (view: EditorView) =>
+                            Boolean(type && findSelectedNodeOfType(view.state.selection, type));
                         const getCurrentLabel = (view: EditorView) => {
                             const result = findSelectedNodeOfType(view.state.selection, type);
                             if (!result) return;

diff --git a/packages/preset-gfm/src/footnote/reference.ts b/packages/preset-gfm/src/footnote/reference.ts
@@ -125,9 +125,8 @@ export const footnoteReference = createNode((utils) => {
                 isBindMode: true,
             });
             if (!inputChipRenderer) return [];
-            const shouldDisplay = (view: EditorView) => {
-                return Boolean(view.hasFocus() && type && findSelectedNodeOfType(view.state.selection, type));
-            };
+            const shouldDisplay = (view: EditorView) =>
+                Boolean(type && findSelectedNodeOfType(view.state.selection, type));
             const getCurrentLabel = (view: EditorView) => {
                 const result = findSelectedNodeOfType(view.state.selection, type);
                 if (!result) return;