Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker example for the async sample app #137

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

samuel-holt
Copy link
Contributor

Overview

Add docker support for the async sample app. The app will run on port 8888 by default.

Updates

  • Add Dockerfile and docker-compose.yml
  • Fix some formatting issues in the sample app

Copy link
Contributor

@izsi-salmon izsi-salmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added a note from when I set up the sample app locally using docker.

2. Using docker-compose:

```
docker-compose up
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we might need to add an extra step here to do docker-compose build first. In my experience I had an error when opening the browser because Docker couldn't find the vendor autoload script needed to load raygun4php dependencies. This was because I installed the dependencies outside of the src folder before setting up Docker. I added them to src but continued to get a not found error until I tried building.

Probably a pretty obvious step but it did get me stuck 😅 would be good to include it, as you need to run docker-compose build every time you make changes before running docker-compose up to see the changes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found out you can do this in one line by running it with the build option: docker-compose up --build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants