Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't save a null value with setcookie() #157

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

darcythomas
Copy link
Contributor

Because of some php api changes, we should not be passing a null value to the setcookie() method. (e.g. fullName)

This PR fixes that.

Copy link
Contributor

@robbieaverill robbieaverill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@sumitramanga sumitramanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, looks good!

@darcythomas darcythomas merged commit f4fbbc3 into master Jun 2, 2023
1 check passed
@darcythomas darcythomas deleted the darcy/zd29134/setcookie-error branch August 17, 2023 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants