Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2123 Fix endpoint_url when use_apigateway is false #2124

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jwilges
Copy link

@jwilges jwilges commented Jun 19, 2020

Description

Update no longer raises an exception while updating endpoint_url with base_path when use_apigateway is False.

Further, when use_apigateway is False, update now also:

  • amends deployed_string with endpoint_url (admittedly, Zappa's formatting for this could be improved)
  • attempts to touch the endpoint based on Zappa's settings

GitHub Issues

See issue #2123 for more information and for further discussion.

@jwilges
Copy link
Author

jwilges commented Jun 19, 2020

Hi @jneves, since you appear to be the sole life-blood for pull requests as of late, would you be able to take a look at this and let me know what you think?

I have deployed and tested this with our Lambdas by pinning:

"zappa@git+https://github.com/jwilges/Zappa@0.51.1.dev2"

I know this is probably annoying to check into, so I tried to provide a reasonable tag to pin and test against to make your life easier.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 73.066% when pulling 1fed733 on jwilges:2123_fix_endpoint_url_when_use_apigateway_false into 93804a1 on Miserlou:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants