New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update render.js #2880
base: next
Are you sure you want to change the base?
Update render.js #2880
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fill out the form. You didn't even check a single box in the checklist. Also, we do try to maintain limited IE support, and our current build system doesn't do let
/const
-> var
conversion.
If you want to attack the bigger step of moving us to modern ES, go for it, but it won't be as simple as just this. Also, please bundle all of the work into just a single pull request.
(If this was discussed on Zulip and I'm wrong here, please let me know so I can dismiss my review.)
This guy is spamming a bunch of repos with the same changes. |
Would like to give some benefit of the doubt, just in case they decide to engage in good faith. Not surprised, though. |
is a spammer, i have the same issue with him. I also blocked him but he can continue to opens pr regardless |
For what it's worth, some of my leniency is because a few of my first open source contributions were similarly garbage quality (to be fair, I was still in high school at the time and had almost no clue what I was doing). |
thanks |
Description
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist:
docs/changelog.md