Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update render.js #2880

Open
wants to merge 1 commit into
base: next
Choose a base branch
from
Open

Conversation

RohitPaul0007
Copy link

Description

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated docs/changelog.md

Copy link
Member

@dead-claudia dead-claudia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fill out the form. You didn't even check a single box in the checklist. Also, we do try to maintain limited IE support, and our current build system doesn't do let/const -> var conversion.

If you want to attack the bigger step of moving us to modern ES, go for it, but it won't be as simple as just this. Also, please bundle all of the work into just a single pull request.

(If this was discussed on Zulip and I'm wrong here, please let me know so I can dismiss my review.)

@boazblake
Copy link
Contributor

This guy is spamming a bunch of repos with the same changes.

RohitPaul0007/tween.js@e892ed8

@dead-claudia
Copy link
Member

This guy is spamming a bunch of repos with the same changes.

RohitPaul0007/tween.js@e892ed8

Would like to give some benefit of the doubt, just in case they decide to engage in good faith.

Not surprised, though.

@asturur
Copy link

asturur commented Sep 6, 2023

This guy is spamming a bunch of repos with the same changes.
RohitPaul0007/tween.js@e892ed8

Would like to give some benefit of the doubt, just in case they decide to engage in good faith.

Not surprised, though.

is a spammer, i have the same issue with him. I also blocked him but he can continue to opens pr regardless

@dead-claudia
Copy link
Member

For what it's worth, some of my leniency is because a few of my first open source contributions were similarly garbage quality (to be fair, I was still in high school at the time and had almost no clue what I was doing).

@RohitPaul0007
Copy link
Author

For what it's worth, some of my leniency is because a few of my first open source contributions were similarly garbage quality (to be fair, I was still in high school at the time and had almost no clue what I was doing).

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants