Convert calculate_output_groups.py into a Swift binary
#3019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brentley Jones <github@brentleyjones.com> Signed-off-by: Matt Pennig <mpennig@slack-corp.com>
Signed-off-by: Matt Pennig <mpennig@slack-corp.com>
Signed-off-by: Matt Pennig <mpennig@slack-corp.com>
pennig
force-pushed
the
pennig/calculate-output-groups
branch
from
9b9e32b
to
8df9065
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance is better than (but comparable to) the python script. Perhaps more importantly, the program looks specifically for the build-request.json file and uses its modification date to compare against the build_marker file's date, instead of comparing the parent .xcbuilddata directory. Not sure if that'll make a difference, but it's a distinction worth calling out.