-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add xcschemes.autogeneration_config #3027
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks useful, thanks! What other configuration options do you see in the future?
@luispadron I think other Besides that, scheme auto-generation might need other customizations in the future not related to exclusion patterns and for that we can add more attributes the macro. But again, instead of over engineering it now I'd rather improve this API as the need arises from consumers. Thoughts? |
6a067dd
to
0df79a3
Compare
Trying to understand this CI failure. Have you ever seen this?
|
Looks like some issue with Bazel HEAD, which we will need to fix outside of this PR. |
0df79a3
to
a7de214
Compare
tools/generators/xcschemes/src/Generator/GeneratorArguments.swift
Outdated
Show resolved
Hide resolved
Signed-off-by: Thiago Cruz <thiago@squareup.com>
Signed-off-by: Thiago Cruz <thiago@squareup.com>
Signed-off-by: Thiago Cruz <thiago@squareup.com>
Signed-off-by: Thiago Cruz <thiago@squareup.com>
Signed-off-by: Thiago Cruz <thiago@squareup.com>
Signed-off-by: Thiago Cruz <thiago@squareup.com>
Signed-off-by: Thiago Cruz <thiago@squareup.com>
Signed-off-by: Thiago Cruz <thiago@squareup.com>
Signed-off-by: Thiago Cruz <thiago@squareup.com>
Signed-off-by: Thiago Cruz <thiago@squareup.com>
Signed-off-by: Thiago Cruz <thiago@squareup.com>
Signed-off-by: Thiago Cruz <thiago@squareup.com>
Signed-off-by: Thiago Cruz <thiago@squareup.com>
Signed-off-by: Thiago Cruz <thiago@squareup.com>
Signed-off-by: Thiago Cruz <thiago@squareup.com>
Signed-off-by: Thiago Cruz <thiago@squareup.com>
Signed-off-by: Thiago Cruz <thiago@squareup.com>
93c56d9
to
8b6bc9b
Compare
Signed-off-by: Thiago Cruz <thiago@squareup.com>
Signed-off-by: Thiago Cruz <thiago@squareup.com>
Co-authored-by: Brentley Jones <github@brentleyjones.com> Signed-off-by: Thiago Cruz <thiago@squareup.com>
a2f4aa3
to
7b00721
Compare
Signed-off-by: Thiago Cruz <thiago@squareup.com>
Signed-off-by: Thiago Cruz <thiago@squareup.com>
Signed-off-by: Thiago Cruz <thiago@squareup.com>
Signed-off-by: Thiago Cruz <thiago@squareup.com>
Signed-off-by: Thiago Cruz <thiago@squareup.com>
Resolves #3013
The proposal is to introduce a
xcschemes.autogeneration_config
macro to allow consumers to configure scheme auto-generation. I'm addressing my particular use case of wanting to exclude certain schemes based on patterns in their names but I'm open to discuss other configurations/exclusion patterns folks might want to add here.In order to test this note how running (from
examples/integration
)bazel run //:xcodeproj-incremental-bazel-sim_arm64
generates a project that does not contain the undesired schemesUndesiredScheme_Swift
andUnwantedScheme_Swift
even though the respective targets do exist.