feat: wip implementation for passing chunk state fo wgpu layer #5125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Pollind <mpollind@gmail.com>
…ses`. unitTests and integrationTests works now
Signed-off-by: Michael Pollind <mpollind@gmail.com>
Signed-off-by: Michael Pollind <mpollind@gmail.com>
Signed-off-by: Michael Pollind <mpollind@gmail.com>
Signed-off-by: Michael Pollind <mpollind@gmail.com>
Signed-off-by: Michael Pollind <mpollind@gmail.com>
Signed-off-by: Michael Pollind <mpollind@gmail.com>
Signed-off-by: Michael Pollind <mpollind@gmail.com>
Signed-off-by: Michael Pollind <mpollind@gmail.com>
Signed-off-by: Michael Pollind <mpollind@gmail.com>
Signed-off-by: Michael Pollind <mpollind@gmail.com>
Signed-off-by: Michael Pollind <mpollind@gmail.com>
Signed-off-by: Michael Pollind <mpollind@gmail.com>
github-actions
bot
added
the
Type: Improvement
pollend
commented
Jul 25, 2023
Comment on lines
-83
to
-84
| public void appendTo(ChunkMesh chunk, ChunkView chunkView, int offsetX, int offsetY, int offsetZ, | ||
| ChunkMesh.RenderType renderType, Colorc colorOffset, ChunkVertexFlag flags) { |
There was a problem hiding this comment.
I don't think we need to pass in the RenderType. if we still want the enumeration for the type we can expose that as a free function.
pollend
force-pushed
the
feature/wgpu-rendering-refactor
branch
from
221e454
to
f3efca5
Compare
jdrueckert
added
the
Status: Needs Author Input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains
Initial planned changes to support chunk meshes into the rust layer. At the moment I'll just stage the chunk meshes on the java side and pass it to wgpu to manage. I'll start with just filling out the position buffer and I'll add more back in as we construct the pipeline for the scene.
Was thinking about indirect rendering but that will be another challenge to approach later. The problem space would include a custom allocator to allocate everything to a single buffer to bind to the render pipeline.
there is this PR that is associated with this change: MovingBlocks/TeraRusty#8