Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: screen merge follow-ups #5241

Merged
merged 6 commits into from
May 16, 2024
Merged

Conversation

jdrueckert
Copy link
Member

@jdrueckert jdrueckert commented May 2, 2024

Contains

  • fix screen title
  • remove verbose label asking the user to pick a world generator from the drop down
  • remove no longer used translation tags
  • return user to module selection if no module selected that provides world generator
  • differentiate between world generator creation issues and display popup to user if selected world generator cannot be resolved

How to test

  1. Start Terasology
  2. Go to advanced game setup
  3. Go to universe setup screen
  4. Confirm above-mentioned changes

Outstanding before merging

  • Check and adjust Re-Roll button height to seed text field height

@github-actions github-actions bot added the Type: Chore Request for or implementation of maintenance changes label May 2, 2024
@jdrueckert jdrueckert added Topic: UI/UX Requests, Issues and Changes related to screens, artwork, sound and overall user experience Status: Needs Testing Requires to be tested in-game for reproducibility and removed Type: Chore Request for or implementation of maintenance changes labels May 2, 2024
@jdrueckert jdrueckert added this to the 2023 Revive - Milestone 3 milestone May 2, 2024
@soloturn
Copy link
Contributor

soloturn commented May 2, 2024

i do get a build error here, not sure what i am doing wrong:

/srv/http/repos/terasology/engine/src/main/java/org/terasology/engine/rendering/nui/layers/mainMenu/UniverseSetupScreen.java:360: error: cannot find symbol
        } catch (UnresolvedDependencyException e) {
                 ^
  symbol:   class UnresolvedDependencyException
  location: class UniverseSetupScreen

tried to fix it, but i am not sure what one needs to select so that drop back is visible.

@github-actions github-actions bot added the Type: Chore Request for or implementation of maintenance changes label May 2, 2024
@jdrueckert
Copy link
Member Author

yeah I must've messed/mixed up the import... GitHub codespaces is not working as well as Intellij when it comes to imports between Terasology and gestalt... also didn't test this yet, so I probably should've opened it as a draft, sorry about that - switching to draft state now.

@jdrueckert jdrueckert marked this pull request as draft May 2, 2024 17:51
@soloturn soloturn force-pushed the chore/screen-merge-followups branch from e385609 to 525036d Compare May 4, 2024 16:39
@soloturn
Copy link
Contributor

soloturn commented May 4, 2024

force pushed my commit with line lenght correct, there was a checkstyle warning. otherwise it builds and works - but i am am a little clueless what should be different from before - so would be cool if you start it once and clcik to the screen you wanted to see a difference? @jdrueckert ?

@soloturn soloturn force-pushed the chore/screen-merge-followups branch from 525036d to f72b3c6 Compare May 5, 2024 07:40
@soloturn soloturn force-pushed the chore/screen-merge-followups branch from f72b3c6 to b08639b Compare May 10, 2024 07:01
@jdrueckert
Copy link
Member Author

jdrueckert commented May 15, 2024

@soloturn I listed the changes I've done in this PR in the description:

  • fix screen title
  • remove verbose label asking the user to pick a world generator from the drop down
  • remove no longer used translation tags
  • return user to module selection if no module selected that provides world generator
  • differentiate between world generator creation issues and display popup to user if selected world generator cannot be resolved

If you navigate to the universe setup screen (Singleplayer -> Create -> Advanced -> Continue to Universe Setup), and compare between develop and this branch, you should be able to notice the frist two aspects. The third one is only visible in-code and the fourth and fifth are indeed hard to test ...

I guess one would need to fiddle with the local state of the CoreWorlds module to force these two. I'll play around a bit and if I can reliably force them, I'll provide instructions how to.
Scratch that, I don't know how to force them... Removing the world generators from the module before compilation doesn't work because then they're not registered in the first place. And the module cannot be disabled in the advanced game setup because all iota modules are mandatory and, thus, always enabled...

@soloturn soloturn marked this pull request as ready for review May 16, 2024 18:18
@soloturn
Copy link
Contributor

if its hard to test, then lets merge it, and fix if somebody really notices a regression.

@soloturn soloturn merged commit 30bc83a into develop May 16, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Testing Requires to be tested in-game for reproducibility Topic: UI/UX Requests, Issues and Changes related to screens, artwork, sound and overall user experience Type: Chore Request for or implementation of maintenance changes
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

2 participants