Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unique blog link #244

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Rukki13
Copy link
Contributor

@Rukki13 Rukki13 commented May 11, 2024

No description provided.

@Rukki13 Rukki13 mentioned this pull request May 11, 2024
@Rukki13 Rukki13 changed the title Unique blog link fix: Unique blog link May 11, 2024
Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@jdrueckert jdrueckert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does work better than the one before. The links on both the homepage latest blog cards as well as on the default blog list page cards work. However, it still breaks for the blog list page cards if you filter the cards.

createPage({
path: `/blog${edge.node.fields.slug}`,
path: `/blog${edge.node.fields.slug}-${edge.node.fields.date.replace(/[-T:.Z]/g, '-').substring(0, 10)}`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prettier would prefer that with newlines like you did in BlogList.jsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants