-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataGrid: Add ability to change filter icons on column headers. #8428
base: dev
Are you sure you want to change the base?
Conversation
* Added ability to change filter icons on datagrid column headers * Added null check
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #8428 +/- ##
==========================================
+ Coverage 88.86% 88.89% +0.02%
==========================================
Files 414 414
Lines 12297 12301 +4
Branches 2455 2460 +5
==========================================
+ Hits 10928 10935 +7
+ Misses 838 836 -2
+ Partials 531 530 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lol was 5 minutes away from creating the PR myself.
Anyways I think you're missing to change the Icon in MudDataGrid.razor line 140 + 144 to the new parameters you've created
Hi. |
@ScarletKuro any ETA on this? This seems like a very small feature. Does it have to be tjscience who has to review it, if he haven't got the time? |
Hi
This does not depend on me, but on @tjscience. I will try to reach him on discord |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sabitertan, thanks for working on this - it seems like a good addition. However, there is an issue. It does not seem like you have covered the scenario where the FilterMode = DataGridFilterMode.ColumnFilterRow
. This mode uses the FilterHeaderCell component and there are filter icons there as well. Everything else looks good.
@sabitertan to make it easier for you, I've just checked the code. It seems that you need to pass the filter icons along in |
@sabitertan can you do the requested changes and fix conflicts? Then I can merge this. |
Description
Replaces: #6238
How Has This Been Tested?
Visually
Types of changes
Checklist:
dev
).