-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MudTable: Added StripedGroups parameter to stripe per group instead of per row. #8604
base: dev
Are you sure you want to change the base?
Conversation
I was looking at the wrong file 😄 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #8604 +/- ##
==========================================
+ Coverage 89.82% 89.87% +0.04%
==========================================
Files 412 412
Lines 11878 11886 +8
Branches 2364 2364
==========================================
+ Hits 10670 10682 +12
+ Misses 681 676 -5
- Partials 527 528 +1 ☔ View full report in Codecov by Sentry. |
I'm not sure how i should write test coverage for the 2 lines that Codecov is mentioning. Any help is appreciated 🙏 |
* Even/Odd css should apply to the correct group based on what the user assumes to be the even/odd group, not a index that starts at 0. * Removed unnecessary footerClass and moved the adding of the class into the cs file. * Added simple test for the classes.
I made some improvements and added a simple test for the striped classes. |
I am not sure about this. I'd rather want a way to allow any kind of custom CSS classes applied per row. Like a |
Description
This adds the parameter
StripedGroups
to the table that can be used togheter with the grouping system to stripe even/odd groups, instead ofStriped
that stripes based on even/odd rows.Open to improvement suggestions, but this implementation works. I tried to do this using only CSS, but that seems impossible. In the end my CSS + C# implementation got so complex that i decided to scrap it and make this PR instead.
How Has This Been Tested?
Visually and simple unit test.
Types of changes
Checklist
dev
).