-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update _fab.scss #8645
base: dev
Are you sure you want to change the base?
Update _fab.scss #8645
Conversation
Updated the mud-fab-extended classes width and height to match the one in the normal mud-fab class.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #8645 +/- ##
==========================================
+ Coverage 89.82% 89.86% +0.03%
==========================================
Files 412 414 +2
Lines 11878 11913 +35
Branches 2364 2364
==========================================
+ Hits 10670 10706 +36
+ Misses 681 676 -5
- Partials 527 531 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and makes sense, but I don't use the FABs so I might not be the one to ask
Probably requires feedback from @Garderoben |
I'll defer this decision to @Garderoben |
Updated the mud-fab-extended classes width and height to match the one in the normal mud-fab class.
Description
Currently a FAB with a
Label
set, i.e. amud-fab-extended
, will not match the sizing of the standard, non-extended, FAB.The
height
,min-width
, andborder-radius
of an extended FAB should be equal to the standard FAB'sheight
,width
, andborder-radius
respectively.How Has This Been Tested?
This is a visual change it's pretty straightforward. See below for screenshots.
Types of changes
Before:
After:
Checklist
dev
).