-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NavLink and NavGroup: IconOnly
Mode
#8809
Conversation
…de for MudNavLink and MudNavGroup components.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #8809 +/- ##
==========================================
+ Coverage 89.82% 90.14% +0.31%
==========================================
Files 412 421 +9
Lines 11878 12215 +337
Branches 2364 2411 +47
==========================================
+ Hits 10670 11011 +341
+ Misses 681 663 -18
- Partials 527 541 +14 ☔ View full report in Codecov by Sentry. |
Should it collapse the title too? Not sure how that would work Side note: the hamburger menu icon should really align with the rest Titles in the new example are too far to the right and don't look right |
@esda98 this example isn't intuitive. Nobody will figure out that they have to click the burger icon to collapse. Just add a MudSwitch at the bottom of the example that says |
Closing due to Drawer.Mini really doing what I wanted to achieve here. I appreciate all the feedback! |
This PR adds a
boolean
property to the MudNavLink and MudNavGroup components that controls the conditional rendering of the child elements of MudNavLink and the Title of MudNavGroup.Description
The PR adds an
if
around the<div>
tags that wrap@ChildContent
for MudNavLink and@Title
for MudNavGroup controlled by the new boolean parameter for the components namedIconOnly
.This is to enable functionality of collapsed sidebars, common in vertical navigation pane paradigms, to save horizontal space but still allow navigation through the icons on the sidebar.
How Has This Been Tested?
Type of Changes
Examples
IconOnlyModeExample.mp4
Checklist
dev
).