-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MudChart: Add TimeSeries line and area chart components #8973
Conversation
…axes add new TimeSeries chart type that can render line or area series along a datetime time x-axis
… is only on the line section and not around the whole shape.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #8973 +/- ##
==========================================
+ Coverage 89.82% 90.50% +0.67%
==========================================
Files 412 397 -15
Lines 11878 12317 +439
Branches 2364 2399 +35
==========================================
+ Hits 10670 11148 +478
+ Misses 681 631 -50
- Partials 527 538 +11 ☔ View full report in Codecov by Sentry. |
src/MudBlazor.Docs/Pages/Components/Charts/Examples/TimeSeriesExample1.razor
Outdated
Show resolved
Hide resolved
I have squashed it down into a single chart with multiple series. |
… is called as part of the legend visibility
Nice, can you post an updated screenshot please? |
edited the first post to reflect |
<SectionHeader Title="Basic Usage"> | ||
<Description> | ||
To get a Line Chart use <CodeInline>Type="TimeSeriesDiplayType.Line"</CodeInline> to render the configured <CodeInline>TimeSeriesChartSeries</CodeInline> as a line graph. | ||
To get an Area Chart use <CodeInline>Type="TimeSeriesDiplayType.Area"</CodeInline> to render the configured <CodeInline>TimeSeriesChartSeries</CodeInline> as a area graph. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small typo, should be: as an area graph
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to merge. Just for my understanding @radderz, what is the reason for introducing the MudCategoryChartBase
?
I think it was merged a bit too early, as it missing explicit bUnit tests which is required by our rules. |
Sorry, I forgot to check for tests :(. Shall we revert and wait for resubmission with tests or will you PR the tests separately @radderz ? |
Basically MudCategoryChartBase is the old MudChartBase and and moved the common parts for the time series to a new MudChartBase, MudCategoryChartBase was all I could think of naming wise for the existing charts that are based on category/value. |
I hadn't planned on doing tests for the timeseries, but based on the line series tests if it basically just did a single chart of each and checked the result matches a known value that'd be straight forward I guess. I don't have time to do this right now but I will do another PR to add the tests if no one has done it in the next few weeks. |
That would be enough. |
Description
Adding a time series version of charts and implementing support for areas and lines to coexist on it. It reused a large amount of the existing line chart code with the changes needed to support time series and area charts. The same approach could be used to make the non time series chart support an area style.
How Has This Been Tested?
Manually tested the created charts and added a docs page.
Type of Changes
Checklist
dev
).