-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace mouse events with pointer events in applicable components #8974
Conversation
Naturally supporst mouse, touch, and pen input uniformly and should be preferred for modern applications All functionality should be the same for mice users - Removed !NET7_0_OR_GREATER code - Renamed MouseEvent.MouseOver -> HoverOver - Renamed MouseEvent -> PointerEvent - Switched a few classes to file scoped namespaces
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #8974 +/- ##
==========================================
+ Coverage 89.82% 90.49% +0.66%
==========================================
Files 412 394 -18
Lines 11878 12139 +261
Branches 2364 2369 +5
==========================================
+ Hits 10670 10985 +315
+ Misses 681 621 -60
- Partials 527 533 +6 ☔ View full report in Codecov by Sentry. |
@henon @ScarletKuro Could I get a bit of help testing the Table and DataGrid? Don't think the resizer is working but I never use those two controls 🤷 |
Shouldn't it just be |
|
Could you compare against v6 behavior to see if something broke. |
Touch can not hover only Mouse can, that's why I think MouseOver is still a good name. |
@henon don't forget pens, etc |
OK let's do |
02a1dcd
to
20a75da
Compare
Tests pass and I've manually checked and all seems the same with mouse. This will help with accessibility. |
I think it would be nice to merge #8972 before this. |
@ScarletKuro Do you mind fixing the conflict for me? Or i can do it when i get home nbd |
Idm, but I will do it tmr in that case, it's pretty late for me now. |
Done |
@henon Should be good now |
I am not sure about the renames. I feel like I'd rather leave the names all the same including the |
It's a good point, either way is fine. Let me know and I'll change them back. @henon |
@henon Public API is now back to |
Thanks! Added to v7.0.0 Migration Guide #8447 |
Description
Naturally supports mouse, touch, and pen (among other) inputs uniformly which improves accessibility and should be preferred for modern applications.
All functionality should be the same for existing mice users
Migration Guide:
TableRowHoverEventArgs
and Table methods now acceptPointerEventArgs
instead ofMouseEventArgs
How Has This Been Tested?
unit, visually
Type of Changes
Checklist
dev
).