-
-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infrastructure: Add Github workflow for compiling 64bit Mudlet with Qt6 for Windows #7217
Conversation
Continuing to build past the first error makes the actual error hard to find, because it'll be swamped with a lot of other text after the error that is not relevant
CI/deploy-mudlet-for-windows.sh
Outdated
if [[ "$PublicTestBuild" == "true" ]]; then | ||
# Allow public test builds to be installed side by side with the release builds by renaming the app | ||
# No dots in the <id>: Guidelines by Squirrel | ||
sed -i "s/<id>Mudlet<\/id>/<id>Mudlet_${BUILD_BITNESS}_-PublicTestBuild<\/id>/" "$NuSpec" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. You must not use a different Id for the 32-bit builds compared to what we were using before - otherwise existing installed Mudlet PTB versions will not see this as an update. For those we were using:
Mudlet-PublicTestBuild
as the id and that is what it must stay as.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Err, I understood that the 32 bit should have remained the same.. I guess i meant to wrap that in a test for MINGW64 but forgot to before I did a commit, oopsie
CI/deploy-mudlet-for-windows.sh
Outdated
# Allow public test builds to be installed side by side with the release builds by renaming the app | ||
# No dots in the <id>: Guidelines by Squirrel | ||
sed -i "s/<id>Mudlet<\/id>/<id>Mudlet_${BUILD_BITNESS}_-PublicTestBuild<\/id>/" "$NuSpec" | ||
sed -i "s/<title>Mudlet<\/title>/<title>Mudlet_${BUILD_BITNESS} (Public Test Build)<\/title>/" "$NuSpec" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The restrictions on the "Title" are not so restricted as for the Id and I think Mudlet x${BUILD_BITNESS} (Public Test Build)
or Mudlet x86 (Public Test Build)
& Mudlet x64 (Public Test Build)
would be more readable in the Windows Installed Applications list. And give a hint to 64 Bit Windows users that there might be an alternative for them.
CI/deploy-mudlet-for-windows.sh
Outdated
sed -i "s/<id>Mudlet<\/id>/<id>Mudlet_${BUILD_BITNESS}_<\/id>/" "$NuSpec" | ||
sed -i "s/<title>Mudlet<\/title>/<title>Mudlet_${BUILD_BITNESS}<\/title>/" "$NuSpec" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same things as the last couple of comments. The id must remain as Mudlet
for the 32 bit release version but should be different for the NEW 64 bit release - and the suggested Id for that is Mudlet_64_
as any form of brackets or braces or an ending with numbers seems to be a problem and dots just borks things right up.
Title can be like I suggest in the previous comments just without the (Public Test Build)
obviously.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets get this merged to see how test and PTB builds work now. appveyor.yml
is gone for now, but will be back with #7226.
Brief overview of PR changes/additions
This is intended to replace Appveyor for the Windows CI/CB process. It successfully creates -testing versions however the ptr and release version building needs to be tested by the Admin team.
Motivation for adding to Mudlet
Other info (issues closed, discussion etc)
Appveyor still attempts to run so the integration probably needs to be removed by the admin staff.