Skip to content

Commit

Permalink
Travis: Stick with node.js 8.11
Browse files Browse the repository at this point in the history 
Awaiting a solution for nodejs/node#22857
  • Loading branch information
@papandreou
papandreou committed Sep 17, 2018
1 parent b268a0f commit df38f5f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .travis.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ cache:
directories:
- node_modules
node_js:
- "8"
- "8.11"
- "9"
- "10"

Expand Down

3 comments on commit df38f5f

@DanielRuf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this?

@papandreou
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was because node.js 8.12 had a regression that broke our HTTP mocking library, so the test suite didn't run. Seems like that was fixed in 8.13 now, though, as evidenced by the CI results on your PR, so we can get rid of it now 🤗

@DanielRuf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so we can get rid of it now

Done in my PR (already) or can be also done separately and I will rebase then.

Please sign in to comment.