Skip to content
This repository has been archived by the owner on Jan 5, 2021. It is now read-only.

Parameters in flags.go are not respected #254

Open
Varunram opened this issue Jun 3, 2018 · 4 comments
Open

Parameters in flags.go are not respected #254

Varunram opened this issue Jun 3, 2018 · 4 comments

Comments

@Varunram
Copy link
Contributor

Varunram commented Jun 3, 2018

Adding extra parameters (e.g. --port) to config/config.std.js are not respected while starting the gmc client. They should be.

@Varunram
Copy link
Contributor Author

Varunram commented Jun 3, 2018

More info on this: We create a file at $HOME/config/ from which the wallet reads the config from. This is good, but this prevents the user from actually changing stuff within /config and then testing it. If we are to improve it in some way, we must either link both the files or have a musicoin.conf file as suggested in https://github.com/Musicoin/desktop-interface/issues/8

@etaletai13
Copy link
Contributor

Let's go ahead and close this with preference to Musicoin/desktop-interface#8 because the full solution is in filling that one.

@Varunram
Copy link
Contributor Author

Yeah, I guess that would be nice, but this is a more popular watched repo than the other one, so makes sense having this as well.

@etaletai13
Copy link
Contributor

Noted and agreed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants