Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9.x #662

Draft
wants to merge 25 commits into
base: main
Choose a base branch
from
Draft

9.x #662

wants to merge 25 commits into from

Conversation

ToppleTheNun
Copy link
Collaborator

@ToppleTheNun ToppleTheNun commented Apr 18, 2022

Break the plugin into an API module and a plugin module to make certain types of changes easier. Also make a few breaking changes to the APIs in the API modules.

@vercel
Copy link

vercel bot commented Apr 18, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mythicdrops ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2023 3:13am

@codecov
Copy link

codecov bot commented Apr 18, 2022

Codecov Report

Patch coverage: 15.00% and project coverage change: -0.09% ⚠️

Comparison is base (133e2ab) 18.15% compared to head (9d69bac) 18.07%.

❗ Current head 9d69bac differs from pull request most recent head 4114a96. Consider uploading reports for the commit 4114a96 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #662      +/-   ##
============================================
- Coverage     18.15%   18.07%   -0.09%     
  Complexity      272      272              
============================================
  Files           263      233      -30     
  Lines          7782     7691      -91     
  Branches        975      967       -8     
============================================
- Hits           1413     1390      -23     
+ Misses         6282     6215      -67     
+ Partials         87       86       -1     
Files Changed Coverage Δ
.../mythicdrops/ClosedFloatingPointRangeExtensions.kt 100.00% <ø> (ø)
...raft/bukkit/mythicdrops/CommandSenderExtensions.kt 57.14% <ø> (ø)
...kkit/mythicdrops/ConfigurationSectionExtensions.kt 66.66% <ø> (ø)
...ukkit/mythicdrops/InventoryClickEventExtensions.kt 0.00% <ø> (ø)
...inecraft/bukkit/mythicdrops/InventoryExtensions.kt 0.00% <ø> (ø)
...inecraft/bukkit/mythicdrops/ItemStackExtensions.kt 0.00% <ø> (ø)
...minecraft/bukkit/mythicdrops/IterableExtensions.kt 0.00% <ø> (ø)
...ube/minecraft/bukkit/mythicdrops/ListExtensions.kt 72.97% <ø> (ø)
...cube/minecraft/bukkit/mythicdrops/MapExtensions.kt 0.00% <ø> (ø)
.../minecraft/bukkit/mythicdrops/MythicDropsPlugin.kt 0.14% <ø> (ø)
... and 142 more

... and 191 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Apr 18, 2022

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 3 0 0.06s
❌ COPYPASTE jscpd yes 83 7.44s
✅ EDITORCONFIG editorconfig-checker 473 0 1.81s
✅ JSON eslint-plugin-jsonc 1 0 0 1.64s
✅ JSON jsonlint 1 0 0.18s
✅ JSON prettier 1 0 0 0.5s
✅ JSON v8r 1 0 2.29s
❌ KOTLIN ktlint 406 18 1 814.89s
✅ MARKDOWN markdownlint 1 0 0 0.5s
✅ MARKDOWN markdown-link-check 1 0 0.5s
✅ MARKDOWN markdown-table-formatter 1 0 0 0.43s
✅ REPOSITORY checkov yes no 26.93s
❌ REPOSITORY devskim yes 1 0.08s
✅ REPOSITORY dustilock yes no 1.01s
❌ REPOSITORY gitleaks yes 7 9.39s
✅ REPOSITORY git_diff yes no 0.04s
✅ REPOSITORY secretlint yes no 3.99s
✅ REPOSITORY syft yes no 0.38s
✅ REPOSITORY trivy yes no 6.21s
❌ SPELL cspell 474 31 22.17s
✅ SPELL misspell 473 0 0 0.36s
✅ XML xmllint 2 0 0 0.05s
✅ YAML prettier 37 5 0 3.72s
❌ YAML v8r 37 1 24.54s
✅ YAML yamllint 37 0 1.71s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

}
}

tasks.withType<ProcessResources> {

Check warning

Code scanning / QDJVM

Unstable API Usage

'org.gradle.language.jvm.tasks.ProcessResources' is declared in unstable package 'org.gradle.language.jvm.tasks' marked with @Incubating
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant