Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Sora (Kingdom Hearts) #164

Merged
merged 1 commit into from
Feb 18, 2024
Merged

Added Sora (Kingdom Hearts) #164

merged 1 commit into from
Feb 18, 2024

Conversation

AbandonedCart
Copy link
Contributor

Infomation

Please use the following form when doing a pull request for amiibo database. Do update the amiibo.json and game_info.json file to prevent error and make sure proper testing had been done. If unsure on game_info.json please use the following format attached below and just set the games as empty array, as it will be auto generated. Tick the checklist before submitting to ensure you have all the required information.

Pull request form

Checklist

  • The ids provided are not spoof.
  • The ids provided are all in lowercase.
  • The game_info.json had been updated with the corresponding ids.
  • Images of amiibo had been provided with the highest quality.

See #162

Apparently GitHub Desktop decided to randomly close the last one.

@AbandonedCart
Copy link
Contributor Author

For some reason, trying to change branches on my end is closing the pull request

@AbandonedCart AbandonedCart reopened this Feb 15, 2024
@N3evin
Copy link
Owner

N3evin commented Feb 16, 2024

I am currently away on a holiday. Will only be back on Monday. Will do it when I'm back.

@AbandonedCart
Copy link
Contributor Author

Sorry for all the spam. I was between computers and nothing wanted to sync. Enjoy your vacation!

@N3evin N3evin merged commit a7fc1a4 into N3evin:dev Feb 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants