fix(module:tree-view): fix innerTrackBy function (#7150)

close #7118 Co-authored-by: viktorplakida <plakyda1@gmail.com>
NG-ZORRO · Jan 13, 2022 · 4484674 · 4484674
1 parent f73be80
commit 4484674
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/components/tree-view/node.ts b/components/tree-view/node.ts
@@ -170,7 +170,7 @@ export class NzTreeVirtualScrollNodeOutletDirective<T> implements OnChanges {
           return true;
         }
       }
-      return false;
+      return ctxChange.previousValue?.data !== ctxChange.currentValue?.data;
     }
     return true;
   }

diff --git a/components/tree-view/tree-virtual-scroll-view.ts b/components/tree-view/tree-virtual-scroll-view.ts
@@ -65,10 +65,12 @@ export class NzTreeVirtualScrollViewComponent<T> extends NzTreeView<T> implement
   innerTrackBy: TrackByFunction<NzTreeVirtualNodeData<T>> = i => i;
 
   ngOnChanges(changes: SimpleChanges): void {
-    if (changes.trackBy && typeof changes.trackBy.currentValue === 'function') {
-      this.innerTrackBy = (index: number, n) => this.trackBy(index, n.data);
-    } else {
-      this.innerTrackBy = i => i;
+    if (changes.trackBy) {
+      if (typeof changes.trackBy.currentValue === 'function') {
+        this.innerTrackBy = (index: number, n) => this.trackBy(index, n.data);
+      } else {
+        this.innerTrackBy = i => i;
+      }
     }
   }