Skip to content

Commit

Permalink
chore(module:*): fix username of a member (#7384)
Browse files Browse the repository at this point in the history
  • Loading branch information
Wenzhao Hu committed Apr 27, 2022
1 parent 6e5376e commit 99f4141
Show file tree
Hide file tree
Showing 6 changed files with 44 additions and 44 deletions.
44 changes: 22 additions & 22 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Expand Up @@ -19,24 +19,24 @@ components/typography/** @hsuanxyz
components/space/** @hsuanxyz
components/resizable/** @hsuanxyz
components/tabs/** @hsuanxyz
components/breadcrumb/** @wendellhu95
components/empty/** @wendellhu95
components/carousel/** @wendellhu95
components/cascader/** @wendellhu95
components/descriptions/** @wendellhu95
components/icon/** @wendellhu95
components/message/** @wendellhu95
components/notification/** @wendellhu95
components/popconfirm/** @wendellhu95
components/popover/** @wendellhu95
components/progress/** @wendellhu95
components/rate/** @wendellhu95
components/result/** @wendellhu95
components/slider/** @wendellhu95
components/statistic/** @wendellhu95
components/timeline/** @wendellhu95
components/tooltip/** @wendellhu95
components/code-editor/** @wendellhu95
components/breadcrumb/** @hullis
components/empty/** @hullis
components/carousel/** @hullis
components/cascader/** @hullis
components/descriptions/** @hullis
components/icon/** @hullis
components/message/** @hullis
components/notification/** @hullis
components/popconfirm/** @hullis
components/popover/** @hullis
components/progress/** @hullis
components/rate/** @hullis
components/result/** @hullis
components/slider/** @hullis
components/statistic/** @hullis
components/timeline/** @hullis
components/tooltip/** @hullis
components/code-editor/** @hullis
components/calendar/** @wenqi73
components/date-picker/** @wenqi73
components/skeleton/** @wenqi73
Expand Down Expand Up @@ -68,11 +68,11 @@ components/pipes/** @chensimeng
components/image/** @stygian-desolator

# The `components/core/*` owners
components/core/config/** @wendellhu95
components/core/element-patch/** @wendellhu95
components/core/config/** @hullis
components/core/element-patch/** @hullis
components/core/highlight/** @hsuanxyz
components/core/resize-observers/** @wendellhu95
components/core/logger/** @wendellhu95
components/core/resize-observers/** @hullis
components/core/logger/** @hullis
components/core/no-animation/** @hsuanxyz
components/core/outlet/** @vthinkxie
components/core/time/** @wenqi73
Expand Down
2 changes: 1 addition & 1 deletion .github/auto_assign.yml
Expand Up @@ -7,7 +7,7 @@ addAssignees: true
# A list of reviewers to be added to pull requests (GitHub user name)
reviewers:
- vthinkxie
- wendellhu95
- hullis
- hsuanxyz
- simplejason
- wenqi73
Expand Down
36 changes: 18 additions & 18 deletions .github/nz-boot.yml
Expand Up @@ -79,24 +79,24 @@ issue:
Typography: hsuanxyz
Space: hsuanxyz
Resizable: hsuanxyz
Breadcrumb: wendellhu95
Empty: wendellhu95
Carousel: wendellhu95
Cascader: wendellhu95
Descriptions: wendellhu95
Icon: wendellhu95
Message: wendellhu95
Notification: wendellhu95
Popconfirm: wendellhu95
Popover: wendellhu95
Progress: wendellhu95
Rate: wendellhu95
Result: wendellhu95
Slider: wendellhu95
Statistic: wendellhu95
Timeline: wendellhu95
Tooltip: wendellhu95
CodeEditor: wendellhu95
Breadcrumb: hullis
Empty: hullis
Carousel: hullis
Cascader: hullis
Descriptions: hullis
Icon: hullis
Message: hullis
Notification: hullis
Popconfirm: hullis
Popover: hullis
Progress: hullis
Rate: hullis
Result: hullis
Slider: hullis
Statistic: hullis
Timeline: hullis
Tooltip: hullis
CodeEditor: hullis
Calendar: wenqi73
DatePicker: wenqi73
Skeleton: wenqi73
Expand Down
2 changes: 1 addition & 1 deletion components/carousel/strategies/transform-strategy.ts
Expand Up @@ -89,7 +89,7 @@ export class NzCarouselTransformStrategy extends NzCarouselBaseStrategy<NzCarous
this.isTransitioning = true;
this.isDragging = false;

// TODO@wendellhu95: use transitionEnd event instead of setTimeout
// TODO@hullis: use transitionEnd event instead of setTimeout
setTimeout(() => {
this.renderer.setStyle(this.slickTrackEl, 'transition', null);
this.contents.forEach((content: NzCarouselContentDirective) => {
Expand Down
2 changes: 1 addition & 1 deletion components/core/types/size.ts
Expand Up @@ -3,7 +3,7 @@
* found in the LICENSE file at https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/LICENSE
*/

// TODO(@wendellhu95): replace other size with this type.
// TODO(@hullis): replace other size with this type.
export type NzSizeLDSType = 'large' | 'default' | 'small';
export type NzSizeMDSType = 'middle' | 'default' | 'small';
export type NzSizeDSType = 'default' | 'small';
2 changes: 1 addition & 1 deletion components/tooltip/tooltip.spec.ts
Expand Up @@ -79,7 +79,7 @@ describe('nz-tooltip', () => {

dispatchMouseEvent(overlayElement, 'mouseleave');
waitingForTooltipToggling();
// FIXME@wendellhu95: the following line errors
// FIXME@hullis: the following line errors
// expect(overlayContainerElement.textContent).not.toContain(title);
// Don't know why this breaks. The website works fine.

Expand Down

0 comments on commit 99f4141

Please sign in to comment.