Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(module:transfer): do not trigger change detection when the checkbox is clicked #7124

Merged
merged 1 commit into from Jan 13, 2022

Conversation

arturovt
Copy link
Member

PR Checklist

PR Type

What kind of change does this PR introduce?

[x] Refactoring (no functional changes, no api changes)

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@zorro-bot
Copy link

zorro-bot bot commented Dec 17, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 17, 2021

Codecov Report

Merging #7124 (fbd71dc) into master (c177558) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7124   +/-   ##
=======================================
  Coverage   91.67%   91.67%           
=======================================
  Files         486      486           
  Lines       15868    15877    +9     
  Branches     2587     2587           
=======================================
+ Hits        14547    14556    +9     
  Misses       1007     1007           
  Partials      314      314           
Impacted Files Coverage Δ
components/transfer/transfer-list.component.ts 96.72% <100.00%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c177558...fbd71dc. Read the comment docs.

Copy link
Member

@hsuanxyz hsuanxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants