Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:transfer): support nzOneWay, nzPagination, nzSelectAllLabels, nzOperationStyle #7239

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Jan 29, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@cipchk cipchk changed the title feat(module:transfer): support nzOperationStyle, nzOneWay WIP feat(module:transfer): support nzOperationStyle, nzOneWay Jan 29, 2022
@zorro-bot
Copy link

zorro-bot bot commented Jan 29, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jan 29, 2022

Codecov Report

Merging #7239 (3a11232) into master (d8ec154) will increase coverage by 0.00%.
The diff coverage is 96.59%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7239   +/-   ##
=======================================
  Coverage   91.60%   91.60%           
=======================================
  Files         487      488    +1     
  Lines       16006    16058   +52     
  Branches     2604     2619   +15     
=======================================
+ Hits        14662    14710   +48     
- Misses       1032     1036    +4     
  Partials      312      312           
Impacted Files Coverage Δ
components/transfer/transfer.module.ts 100.00% <ø> (ø)
components/transfer/transfer-list.component.ts 93.05% <90.90%> (-3.67%) ⬇️
...omponents/transfer/transfer-list-item.component.ts 100.00% <100.00%> (ø)
components/transfer/transfer.component.ts 94.07% <100.00%> (+0.79%) ⬆️
components/tabs/tab-nav-bar.component.ts 86.52% <0.00%> (-1.42%) ⬇️
components/dropdown/dropdown-menu.component.ts 94.11% <0.00%> (+8.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8ec154...3a11232. Read the comment docs.

@cipchk cipchk changed the title WIP feat(module:transfer): support nzOperationStyle, nzOneWay WIP feat(module:transfer): support nzOperationStyle, nzOneWay, nzPagination Jan 29, 2022
@cipchk cipchk requested a review from wenqi73 as a code owner January 29, 2022 12:07
@cipchk cipchk changed the title WIP feat(module:transfer): support nzOperationStyle, nzOneWay, nzPagination WIP feat(module:transfer): support nzOneWay, nzPagination, nzSelectAllLabels, nzOperationStyle Jan 29, 2022
@cipchk cipchk changed the title WIP feat(module:transfer): support nzOneWay, nzPagination, nzSelectAllLabels, nzOperationStyle feat(module:transfer): support nzOneWay, nzPagination, nzSelectAllLabels, nzOperationStyle Jan 29, 2022
@cipchk
Copy link
Member Author

cipchk commented Jan 29, 2022

@arturovt About #7124, this may no longer happen when I refactor, could you pls review? I have a Demo of 13.0.0 here, can I reproduce it based on demo?

@cipchk cipchk requested a review from arturovt February 12, 2022 11:36
@simplejason
Copy link
Member

@cipchk Some tests failed, please fix them first :)

@simplejason
Copy link
Member

@cipchk Any progress?

@cipchk
Copy link
Member Author

cipchk commented Mar 4, 2022

@simplejason 抱歉,最近工作太忙,没有及时处理,已修复 。

@simplejason
Copy link
Member

simplejason commented Apr 21, 2022

@simplejason 抱歉,最近工作太忙,没有及时处理,已修复 。

目前发现左右传输未正确渲染问题、dom 结构与 ant-design 不同步问题,我之后单独提 PR 修复

@cipchk
Copy link
Member Author

cipchk commented Apr 22, 2022

@simplejason 抱歉,最近工作太忙,没有及时处理,已修复 。

目前发现左右传输未正确渲染问题、dom 结构与 ant-design 不同步问题,我之后单独提 PR 修复

OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants