Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:tree-view): fix innerTrackBy function #7118 #7150

Conversation

plakyda-codefresh
Copy link
Contributor

@plakyda-codefresh plakyda-codefresh commented Dec 24, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

  1. default innerTrackBy function value being assigned on each OnChanges call
  2. during scroll further and back of VirtualTree, nodes is broken

Issue Number: #7118

What is the new behavior?

  1. innerTrackBy function value being assigned only in case when @Input trackBy changing
  2. VirtualTree scroll recreates nodes as it should be

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Dec 24, 2021

Codecov Report

Merging #7150 (d9329e6) into master (c177558) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7150   +/-   ##
=======================================
  Coverage   91.67%   91.67%           
=======================================
  Files         486      486           
  Lines       15868    15868           
  Branches     2587     2587           
=======================================
  Hits        14547    14547           
  Misses       1007     1007           
  Partials      314      314           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c177558...d9329e6. Read the comment docs.

Copy link
Member

@hsuanxyz hsuanxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@plakyda-codefresh
Copy link
Contributor Author

plakyda-codefresh commented Jan 3, 2022

@hsuanxyz thanks 🙏
any plans to release?
it's broken in documentation

image

@simplejason simplejason merged commit 4484674 into NG-ZORRO:master Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants