Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:select): fix input width in tags mode #7409

Closed
wants to merge 1 commit into from

Conversation

sebcam
Copy link
Contributor

@sebcam sebcam commented May 4, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

when searching in a select in tags mode, the input field has a constant width to 75px, making the input scrolling when the text take more than 75px.

What is the new behavior?

The input element is correctly resized depending the search text.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented May 4, 2022

This preview will be available after the AzureCI is passed.

@pr-triage pr-triage bot added the PR: draft label May 4, 2022
@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #7409 (2da7810) into master (f09ba57) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #7409   +/-   ##
=======================================
  Coverage   91.61%   91.61%           
=======================================
  Files         487      487           
  Lines       16043    16045    +2     
  Branches     2610     2610           
=======================================
+ Hits        14698    14700    +2     
  Misses       1031     1031           
  Partials      314      314           
Impacted Files Coverage Δ
components/select/select-search.component.ts 89.79% <100.00%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f09ba57...2da7810. Read the comment docs.

@sebcam sebcam marked this pull request as ready for review May 4, 2022 01:09
@sebcam sebcam requested a review from vthinkxie as a code owner May 4, 2022 01:09
@sebcam
Copy link
Contributor Author

sebcam commented Jun 2, 2022

any plan for this ?

@danvy
Copy link

danvy commented Jun 15, 2022

@vthinkxie Any chance to get this PR approved ?

@simplejason
Copy link
Member

I'm not sure if this is releated to the PR(#7626), if both of them solve the same problem, I will only merge one of the two PRs

@sebcam
Copy link
Contributor Author

sebcam commented Sep 26, 2022

@simplejason, indeed, it seems to solve the same problem.

@simplejason
Copy link
Member

I close this PR since #7626 has been merged, if there still has the same bug, we need to create a new PR to fix it.

@simplejason simplejason closed this Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants