Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(module:auto-complete): add status setting demo #7474

Merged
merged 1 commit into from Jun 2, 2022
Merged

docs(module:auto-complete): add status setting demo #7474

merged 1 commit into from Jun 2, 2022

Conversation

buqiyuan
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented May 29, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented May 29, 2022

Codecov Report

Merging #7474 (89e67d8) into master (40815ad) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7474      +/-   ##
==========================================
- Coverage   91.58%   91.57%   -0.02%     
==========================================
  Files         496      496              
  Lines       16418    16418              
  Branches     2548     2548              
==========================================
- Hits        15037    15035       -2     
- Misses       1057     1058       +1     
- Partials      324      325       +1     
Impacted Files Coverage Δ
components/tabs/tab-nav-bar.component.ts 87.23% <0.00%> (-0.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40815ad...89e67d8. Read the comment docs.

@simplejason
Copy link
Member

simplejason commented May 29, 2022

Because autocomplete and input are used together, I suggest waiting for this PR to be merged and then reusing the nzStatus property of input directly instead of adding nzStatus to autocomplete component.

<input nz-input [(ngModel)]="value" [nzAutocomplete]="auto" nzStatus="error">
<nz-autocomplete [nzDataSource]="['12345', '23456', '34567']" #auto></nz-autocomplete>

@buqiyuan
Copy link
Collaborator Author

Because autocomplete and input are used together, I suggest waiting for this PR to be merged and then reusing the nzStatus property of input directly instead of adding nzStatus to autocomplete component.

<input nz-input [(ngModel)]="value" [nzAutocomplete]="auto" nzStatus="error">
<nz-autocomplete [nzDataSource]="['12345', '23456', '34567']" #auto></nz-autocomplete>

👌OK!

@simplejason
Copy link
Member

@buqiyuan Please add some demos for status with nz-input if you have time to deal with this PR :)

@buqiyuan buqiyuan changed the title feat(module:auto-complete): support setting status docs(module:auto-complete): add status setting demo May 31, 2022
@buqiyuan
Copy link
Collaborator Author

@buqiyuan Please add some demos for status with nz-input if you have time to deal with this PR :)

done!

Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simplejason simplejason merged commit 90c7168 into NG-ZORRO:master Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants