refactor: deprecated InputBoolean, InputNumber and InputCssPixel #8487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This preview will be available after the AzureCI is passed. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8487 +/- ##
==========================================
- Coverage 91.56% 91.51% -0.06%
==========================================
Files 532 535 +3
Lines 18337 18424 +87
Branches 2803 2814 +11
==========================================
+ Hits 16790 16860 +70
- Misses 1229 1245 +16
- Partials 318 319 +1 ☔ View full report in Codecov by Sentry. |
|
WIP |
HyperLife1119
force-pushed
the
refactor/deprecated-custom-input-decorators
branch
from
f1088a4
to
f4df9ce
Compare
HyperLife1119
force-pushed
the
refactor/deprecated-custom-input-decorators
branch
2 times, most recently
from
1f07e94
to
19869a3
Compare
|
围观 ing 🍉 |
HyperLife1119
force-pushed
the
refactor/deprecated-custom-input-decorators
branch
2 times, most recently
from
a8dce6b
to
4a9d345
Compare
HyperLife1119
force-pushed
the
refactor/deprecated-custom-input-decorators
branch
from
4a9d345
to
286051d
Compare
HyperLife1119
requested review from
OriginRing,
Ricbet,
danranVm,
simplejason,
vthinkxie,
wenqi73,
hsuanxyz and
cipchk
as code owners
I did it 🥹 |
Laffery
reviewed
Jun 1, 2024
Laffery
reviewed
Jun 1, 2024
Laffery
reviewed
Jun 1, 2024
| @Input() @InputNumber() nzStep = 1; | ||
| @Input({ transform: numberAttribute }) nzMax = 100; | ||
| @Input({ transform: numberAttribute }) nzMin = 0; | ||
| @Input({ transform: numberAttributeWithZeroFallback }) nzStep = 1; |
There was a problem hiding this comment.
nzStep's fallback value should be 1
There was a problem hiding this comment.
As far as I can see, the old @InputNumber decorator has a fallbackValue of 0. Changing the fallbackValue to 1 breaks the should stop at new steps when step=null or dots=true test case, because nzStep also supports passing in null
Laffery
reviewed
Jun 1, 2024
Laffery
reviewed
Jun 1, 2024
Laffery
requested changes
Jun 1, 2024
HyperLife1119
force-pushed
the
refactor/deprecated-custom-input-decorators
branch
3 times, most recently
from
87df1bb
to
1369b5e
Compare
HyperLife1119
force-pushed
the
refactor/deprecated-custom-input-decorators
branch
from
1369b5e
to
9b41fc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information