Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(module:back-top): remove the redundant changeDetectorRef #8538

Merged
merged 1 commit into from
May 20, 2024

Conversation

is-tongben
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@is-tongben is-tongben requested a review from cipchk as a code owner May 14, 2024 05:44
Copy link

zorro-bot bot commented May 14, 2024

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.57%. Comparing base (81ef077) to head (c00039e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8538      +/-   ##
==========================================
- Coverage   91.57%   91.57%   -0.01%     
==========================================
  Files         533      533              
  Lines       18336    18335       -1     
  Branches     2801     2801              
==========================================
- Hits        16792    16791       -1     
  Misses       1226     1226              
  Partials      318      318              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HyperLife1119 HyperLife1119 changed the title perf: changeDetectorRef重复注入 perf(module:back-top): remove the redundant changeDetectorRef May 14, 2024
Copy link
Collaborator

@HyperLife1119 HyperLife1119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OriginRing OriginRing merged commit c1e39e7 into NG-ZORRO:master May 20, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants