Fix destructuring assignment in arrow functions. (babel#8916)

Fixes 8912.
NMinhNguyen · Nov 25, 2018 · 57e656d · 57e656d
1 parent ef2a539
commit 57e656d
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 1 deletion.
diff --git a/src/index.js b/src/index.js
@@ -540,7 +540,12 @@ export default declare((api, options) => {
         destructuring.init(node.left, ref || node.right);
 
         if (ref) {
-          nodes.push(t.expressionStatement(t.cloneNode(ref)));
+          if (path.parentPath.isArrowFunctionExpression()) {
+            path.replaceWith(t.blockStatement([]));
+            nodes.push(t.returnStatement(t.cloneNode(ref)));
+          } else {
+            nodes.push(t.expressionStatement(t.cloneNode(ref)));
+          }
         }
 
         path.replaceWithMultiple(nodes);

diff --git a/test/fixtures/destructuring/assignment-arrow-function-block/input.js b/test/fixtures/destructuring/assignment-arrow-function-block/input.js
@@ -0,0 +1 @@
+() => { [a, b] = [1, 2] }
diff --git a/test/fixtures/destructuring/assignment-arrow-function-block/output.js b/test/fixtures/destructuring/assignment-arrow-function-block/output.js
@@ -0,0 +1,4 @@
+() => {
+  a = 1;
+  b = 2;
+};
diff --git a/test/fixtures/destructuring/assignment-arrow-function-no-block/input.js b/test/fixtures/destructuring/assignment-arrow-function-no-block/input.js
@@ -0,0 +1 @@
+() => [a, b] = [1, 2]
diff --git a/test/fixtures/destructuring/assignment-arrow-function-no-block/output.js b/test/fixtures/destructuring/assignment-arrow-function-no-block/output.js
@@ -0,0 +1,6 @@
+() => {
+  var _ref = [1, 2];
+  a = _ref[0];
+  b = _ref[1];
+  return _ref;
+};