#219: Upgrade electron to v12, migrate to @electron/remote, and set c…

…ontextIsolation to false

app/app/analysis/analysisController.js

@@ -26,10 +26,9 @@
  *  ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  **********************************************************************************************************************/
 import jetpack from 'fs-jetpack';
-import {remote} from 'electron';
+import { dialog } from '@electron/remote';
 import {shell} from 'electron';
 import path from 'path';
-const {dialog} = remote;
 
 export class AnalysisController {
 

app/app/bcl/modalBclController.js

@@ -26,9 +26,7 @@
  *  ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  **********************************************************************************************************************/
 import jetpack from 'fs-jetpack';
-//const {shell} = require('electron');
-import {remote} from 'electron';
-const {shell} = remote;
+import { shell } from '@electron/remote';
 
 export class ModalBclController {
 

app/app/index.run.js

@@ -27,17 +27,16 @@
  **********************************************************************************************************************/
 /*global bootlint*/
 
-import {remote} from 'electron';
-const {app, Menu, shell} = remote;
+import { app, getGlobal, Menu, shell } from '@electron/remote';
 
 export function runBlock($rootScope, $state, $window, $document, $translate, toastr, MeasureManager, DependencyManager, Project, BCL, OsServer, SetProject, OpenProject, $log, Message) {
   'ngInject';
 
   let exitReady = false;
 
   $window.onbeforeunload = e => {
-    console.log('EXIT BUTTON CLICKED?: ', remote.getGlobal('exitClicked'));
-    if (!exitReady && remote.getGlobal('exitClicked')) {
+    console.log('EXIT BUTTON CLICKED?: ', getGlobal('exitClicked'));
+    if (!exitReady && getGlobal('exitClicked')) {
       try {
         // only if project is set
         if (Project.getProjectDir() != null) {

app/app/main/dependencyManagerService.js

@@ -25,8 +25,7 @@
  *  AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
  *  ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  **********************************************************************************************************************/
-import {remote} from 'electron';
-const {app} = remote;
+import { app } from '@electron/remote';
 import jetpack from 'fs-jetpack';
 import AdmZip from 'adm-zip';
 import https from 'https';

app/app/main/measureManagerService.js

@@ -25,9 +25,7 @@
  *  AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
  *  ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  **********************************************************************************************************************/
-import {remote} from 'electron';
 import openport from 'openport';
-const {app} = remote;
 
 export class MeasureManager {
   constructor($log, $http, $q, DependencyManager, Message) {

app/app/project/modalOpenProjectController.js

@@ -25,9 +25,7 @@
  *  AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
  *  ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  **********************************************************************************************************************/
-import {remote} from 'electron';
-
-const {app} = remote;
+import { app } from '@electron/remote';
 
 export class ModalOpenProjectController {
 

app/app/project/modalSetMeasuresDirController.js

@@ -25,8 +25,7 @@
  *  AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
  *  ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  **********************************************************************************************************************/
-import {remote} from 'electron';
-const {dialog} = remote;
+import { dialog } from '@electron/remote';
 
 export class ModalSetMeasuresDirController {
 

app/app/project/openProjectService.js

@@ -25,9 +25,7 @@
  *  AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
  *  ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  **********************************************************************************************************************/
-import {remote} from 'electron';
-
-const {dialog} = remote;
+import { dialog } from '@electron/remote';
 
 export class OpenProject {
   constructor($q, $log, $uibModal, Message) {

app/app/project/osServerService.js

@@ -26,8 +26,7 @@
  *  ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  **********************************************************************************************************************/
 import jetpack from 'fs-jetpack';
-import {remote} from 'electron';
-const {app} = remote;
+import { app } from '@electron/remote';
 import path from 'path';
 import os from 'os';
 import AdmZip from 'adm-zip';

app/app/project/projectService.js

@@ -28,13 +28,11 @@
 import jetpack from 'fs-jetpack';
 //import os from 'os';
 import path from 'path';
-import {remote} from 'electron';
+import { app, dialog } from '@electron/remote';
 import jsZip from 'jszip';
 import fs from 'fs';
 import archiver from 'archiver';
 
-const {app, dialog} = remote;
-
 export class Project {
   constructor($q, $log, $http, $uibModal, MeasureManager, $sce, Message, toastr, $translate) {
     'ngInject';

app/app/project/setProjectService.js

@@ -26,12 +26,10 @@
  *  ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  **********************************************************************************************************************/
 import jetpack from 'fs-jetpack';
-import {remote} from 'electron';
+import { dialog } from '@electron/remote';
 import fs from 'fs';
 import path from 'path';
 
-const {dialog} = remote;
-
 export class SetProject {
   constructor($q, $log, $state, $uibModal, Project, OsServer, BCL, $translate, toastr, Message) {
     'ngInject';

app/app/reports/reportsController.js

@@ -28,10 +28,8 @@
 import jetpack from 'fs-jetpack';
 import os from 'os';
 import path from 'path';
-import {remote} from 'electron';
+import { app } from '@electron/remote';
 import { getEnv } from '../../env';
-
-const {app} = remote;
 export class ReportsController {
 
   constructor($log, Project, $scope, Message) {

app/background.js

@@ -34,6 +34,8 @@ import { app } from 'electron';
 import createWindow from './electron/window';
 import { getEnv } from './env';
 
+require('@electron/remote/main').initialize();
+
 app.on('ready', () => {
 
   const mainWindow = createWindow('main', {
@@ -42,6 +44,7 @@ app.on('ready', () => {
     webPreferences: {
       enableRemoteModule: true,
       nodeIntegration: true,
+      contextIsolation: false,
       webviewTag: true,
       webSecurity: false // Disable the same-origin policy when using http
     }

app/electron/context_menu.js

@@ -25,9 +25,8 @@
  *  AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
  *  ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  **********************************************************************************************************************/
-import {remote} from 'electron';
+import { app, getCurrentWindow, Menu, MenuItem } from '@electron/remote';
 import jetpack from 'fs-jetpack';
-const {app, Menu, MenuItem} = remote;
 
 const env = jetpack.cwd(app.getAppPath()).read('env.json', 'json');
 
@@ -73,14 +72,14 @@ const env = jetpack.cwd(app.getAppPath()).read('env.json', 'json');
     e.preventDefault();
     if (env.name == 'development') {
       rightClickPosition = {x: e.x, y: e.y};
-      remote.getCurrentWindow().inspectElement(rightClickPosition.x, rightClickPosition.y);
+      getCurrentWindow().inspectElement(rightClickPosition.x, rightClickPosition.y);
     }
 
     // Set the default context menu (cut, copy, paste) in all input textarea fields elements
     switch (e.target.nodeName) {
       case 'TEXTAREA':
       case 'INPUT':
-        textMenu.popup(remote.getCurrentWindow());
+        textMenu.popup(getCurrentWindow());
         break;
     }
   }, false);