Upgrade electron to v20 #223
Conversation
…"npm ci" for app postinstall
…enDialog() and dialog.showMessageBox() functions, and update MacOS release task to rename new helper apps
…place deprecated Buffer() with Buffer.from()
…ontextIsolation to false
…dify gulp start task so server is ready before electron build command runs
… for native Apple Silicon support
|
@bstein This looks great. I tested the installers out and ran a simple analysis and all looked good on my end. |
There was a problem hiding this comment.
^1.7.11 → ~20.0.1🤯
Wow @bstein, thank you for making this upgrade!
Everything looks good to me except the server tab is not loading the server view (it says cannot GET url...)
I haven't used PAT in a while so i'm not sure when this page stopped working, but perhaps during this update? @tijcolem, have you noticed this before?
|
@kflemin Those are NREL internal URLs http://bball-13055.nrel.gov:8080. Maybe this was something saved in one of your PAT build projects? If this is something in PAT itself we'd want to get this removed |
|
@tijcolem, this page should show whatever server PAT connected to (remote , local, whatever). I just happened to connect to that one. I haven't tested with other ones or local or anything. Can you get that page to show any server? |
|
@kflemin Okay, I see what you are saying. I tested out the 3.4.0 release and it shows the page with server dashboard as it appears on http://localhost:8080. But when I test with the updated electron app v20I get the blank screen. 3.4.0 server screen (electron v1) 3.4.0 server screen (electron v20) @bstein Could you investigate? |
|
It appears there were some changes in Electron v16 related to the This PR should now be ready for re-review 👍 |
|
Fantastic! Going to merge. |
This pull request bumps the version of electron from v1.7.11 to v20.0.3 and includes fixes for breaking changes that were introduced in various major versions of electron. A detailed account of changes by version is available in #219.
Additionally, because electron v11 and later support running natively on Apple Silicon, I updated the build command for MacOS to target MacOS 11 Big Sur as well as both x86 and ARM. The updated command builds a Universal App which can be installed on both Intel and Apple Silicon Macs without requiring emulation.