Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vgpu-manager] update firmware search path #21

Merged
merged 1 commit into from
Jun 7, 2024
Merged

[vgpu-manager] update firmware search path #21

merged 1 commit into from
Jun 7, 2024
+45 −1

Conversation

cdesiniotis
Copy link
Contributor

@cdesiniotis cdesiniotis commented Apr 11, 2024 •
edited

No description provided.

@tariq1890
Copy link
Contributor

Let's do this is in rhel9 as well please

@cdesiniotis
Copy link
Contributor Author

Let's do this is in rhel9 as well please

We currently do not have a rhel9 directory for the vGPU Manager image.

ArangoGutierrez
ArangoGutierrez requested changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@ArangoGutierrez ArangoGutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you re-write the commit message/ PR tittle so it doesn't show as both title and message as is happening right now

@cdesiniotis
[vgpu-manager] update firmware search path
8057298 
This allows the nvidia kernel module to properly find the path to the GSP firmware
files that are installed in the driver container.

Signed-off-by: Christopher Desiniotis <cdesiniotis@nvidia.com>
@cdesiniotis cdesiniotis changed the title [vgpu-manager] update firmware search path so nvidia kernel module ca… [vgpu-manager] update firmware search path May 21, 2024
@cdesiniotis
Copy link
Contributor Author

Could you re-write the commit message/ PR tittle so it doesn't show as both title and message as is happening right now

Done.

ping @shivamerla for a re-review.

@tariq1890
Copy link
Contributor

@cdesiniotis Can this be merged?

@cdesiniotis cdesiniotis merged commit 497684d into NVIDIA:main Jun 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tariq1890 tariq1890 tariq1890 approved these changes

@ArangoGutierrez ArangoGutierrez ArangoGutierrez approved these changes

@shivamerla shivamerla shivamerla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cdesiniotis @tariq1890 @ArangoGutierrez @shivamerla