Find libnvidia-ml in driver root #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdesiniotis
reviewed
Apr 5, 2024
pkg/nvcdi/lib.go
Outdated
| var nvmlOpts []nvml.Option | ||
| candidates, err := l.driver.Libraries().Locate("libnvidia-ml.so.1") | ||
| if err != nil { | ||
| l.logger.Warningf("Ignoring error in locating libnvidia-ml.so.1: %v", err) |
There was a problem hiding this comment.
Why ignore the error? If we can't find libnvidia-ml.so.1 here then wouldn't we be failing at a later point anyways when we try to initialize NVML?
There was a problem hiding this comment.
The primary reason is that I didn't want to change existing behaviour unintentionally.
Without this change CDI spec generation fails when running with a driver container. |
elezar
force-pushed
the
cdi-generation-with-driver-root
branch
from
544e5e4
to
33b332f
Compare
elezar
force-pushed
the
cdi-generation-with-driver-root
branch
2 times, most recently
from
fef07f1
to
ca00c3b
Compare
This change ensures that the driver root is used to locate libnvidia-ml.so.1 if required. Signed-off-by: Evan Lezar <elezar@nvidia.com>
elezar
force-pushed
the
cdi-generation-with-driver-root
branch
from
ca00c3b
to
c5eda7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.