Update npm request module #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 28, 2017 12:20
… latest build versions. Ensured all code passed Standard Linting. Ensured all tests passed with updated modules
|
Great work @rhernand3z!
Can you link me to the issue in |
|
Hi Buddy, I added the issue URL in the CHANGELOG for this version bump:
|
|
YOU ARE A HERO |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates all NPM modules to newer stable releases. Mainly to fix a bug from the current request module version this module was using that threw a weird POST invalid URI error that has been fixed on a newer version.
By running npm run test, the latest Standard JS spec expected
new Error()when rejecting a promise. See: https://eslint.org/docs/rules/prefer-promise-reject-errorsTested and linted all code. 👍